Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): hide scroller buttons when there are no menuItems #12059

Merged
merged 8 commits into from
Oct 2, 2024
Merged

fix(masthead): hide scroller buttons when there are no menuItems #12059

merged 8 commits into from
Oct 2, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Sep 27, 2024 •
edited
Loading

Related Ticket(s)

ADMCS-6215

Description

This bug fix covers the edge case of the l0Data on the <c4d-masthead-l1> component being undefined or empty.

Testing instructions

  • Open up the Masthead > With L1 story
  • Check off the "Use empty data for L1 menu items". This will employ an L1 dataset that does not have any menuItems defined.
  • The scroller buttons should be hidden

Changelog

Changed

  • Handle the edge case of the l0Data being undefined.

@m4olivei m4olivei added bug Something isn't working adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing v2 labels Sep 27, 2024
@m4olivei m4olivei requested a review from a team as a code owner September 27, 2024 13:44
@m4olivei m4olivei requested review from kennylam, emyarod, bruno-amorim, andy-blum and Valentin-Sorin-Nicolae and removed request for a team September 27, 2024 13:44
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 27, 2024 •
edited
Loading

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12059/index.html

Built with commit: 00859699f408fac8f96c10c2f6c09cd2f30ef6eb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 27, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12059/index.html

Built with commit: 00859699f408fac8f96c10c2f6c09cd2f30ef6eb

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 27, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12059/index.html

Built with commit: 00859699f408fac8f96c10c2f6c09cd2f30ef6eb

@m4olivei m4olivei requested a review from andy-blum September 30, 2024 13:46
emyarod
emyarod approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Oct 2, 2024
@kodiakhq kodiakhq bot merged commit 1760d41 into carbon-design-system:main Oct 2, 2024
15 of 19 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hey there! This issue/pull request was referenced in recently released v2.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-blum andy-blum andy-blum approved these changes

@emyarod emyarod emyarod approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae Awaiting requested review from Valentin-Sorin-Nicolae

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m4olivei @ibmdotcom-bot @emyarod @andy-blum