Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conten-group-heading): render h3 tag to light DOM #12074

Merged
merged 12 commits into from
Oct 25, 2024
Merged

fix(conten-group-heading): render h3 tag to light DOM #12074

merged 12 commits into from
Oct 25, 2024

Conversation

marcelojcs
Copy link
Contributor

Related Ticket(s)

JIRA

Description

Google analytics tools can't pickup on heading elements in shadowroots. We've been asked to adjust content-group-heading elements.
This PR addresses the issue by rendering an h3 element to the light DOM.

Changelog

the content-group-heading component will now wrap the slotted markup in and

and write the result to the light DOM for SEO purposes

@marcelojcs marcelojcs requested a review from a team as a code owner October 14, 2024 13:44
@marcelojcs marcelojcs requested review from kennylam, annawen1, m4olivei, bruno-amorim, andy-blum and Valentin-Sorin-Nicolae and removed request for a team October 14, 2024 13:44
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 14, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12074/index.html

Built with commit: ec561e5f31d21ec04686ad3c12d4857d6ffc1dff

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 14, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12074/index.html

Built with commit: ec561e5f31d21ec04686ad3c12d4857d6ffc1dff

andy-blum
andy-blum previously approved these changes Oct 14, 2024
View reviewed changes
@andy-blum
Copy link
Member

Percy is showing some changes to the typography. @marcelojcs can you take a look here?

Screenshot 2024-10-15 at 8 07 02 AM Screenshot 2024-10-15 at 8 07 08 AM Screenshot 2024-10-15 at 8 07 16 AM

@marcelojcs marcelojcs requested a review from andy-blum October 16, 2024 18:38
@m4olivei m4olivei added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Oct 24, 2024
@m4olivei m4olivei closed this Oct 24, 2024
@m4olivei m4olivei reopened this Oct 24, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12074/index.html

Built with commit: ec561e5f31d21ec04686ad3c12d4857d6ffc1dff

m4olivei
m4olivei approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m4olivei m4olivei requested a review from andy-blum October 24, 2024 21:07
@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Oct 25, 2024
@kodiakhq kodiakhq bot merged commit cf153d0 into carbon-design-system:main Oct 25, 2024
19 of 32 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hey there! This issue/pull request was referenced in recently released v2.14.0.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hey there! This issue/pull request was referenced in recently released v2.14.0.

@m4olivei m4olivei mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-blum andy-blum andy-blum approved these changes

@m4olivei m4olivei m4olivei approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae Awaiting requested review from Valentin-Sorin-Nicolae

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcelojcs @ibmdotcom-bot @andy-blum @m4olivei