Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-card): fix feature card broken styles and refactor #12082

Merged
merged 9 commits into from
Oct 25, 2024

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Oct 24, 2024

Related Ticket(s)

ADCMS-6497

Description

The <c4d-feature-card> has been broken for some time. This PR is a refactor of the styles to align with the v2 Figma specs.

Testing instructions

This ended up being close to a ground-up rewrite of the styles for <c4d-feature-card>. The Storybook should be compared with the Figma specs for all spacing, type, colors, interaction states, inverse states, Carbon themes, etc.

Some things to note:

  • We're testing two stories: Feature card > Medium and Feature card > Large. There are slight differences between them. There is a set of specs for each in Figma.
  • In Storybook there is a tab titled "Carbon Theme" to let you switch between themes.
  • In Storybook you can change the "Color scheme" to inverse in the Knobs panel.

Changelog

Changed

  • Refactors <c4d-feature-card> per the v2 spec

@m4olivei m4olivei changed the title Fix/feature card broken fix(feature-card): fix feature card broken styles and refactor Oct 24, 2024
@m4olivei m4olivei added bug Something isn't working v2 dev Needs some dev work labels Oct 24, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 24, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 24, 2024

@m4olivei m4olivei marked this pull request as ready for review October 24, 2024 19:00
@m4olivei m4olivei requested a review from a team as a code owner October 24, 2024 19:00
@m4olivei m4olivei requested review from ariellalgilmore and IgnacioBecerra and removed request for a team October 24, 2024 19:00
@andy-blum andy-blum added the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Oct 25, 2024
@andy-blum
Copy link
Member

While this would be against content guidance, can we make the component stretch vertically when extremely long content is entered? Perhaps we can use the grid/pseudo-element tricks we did in the caem-tile?
Screenshot 2024-10-24 at 9 19 27 PM
Screenshot 2024-10-24 at 9 20 09 PM

@andy-blum andy-blum requested a review from areagan1030 October 25, 2024 14:18
@andy-blum andy-blum added Ready to merge Label for the pull requests that are ready to merge and removed Needs design approval PRs on feature requests and new components have to get design approval before merge. labels Oct 25, 2024
@kodiakhq kodiakhq bot merged commit 465a022 into carbon-design-system:main Oct 25, 2024
13 of 18 checks passed
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hey there! This issue/pull request was referenced in recently released v2.14.0.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hey there! This issue/pull request was referenced in recently released v2.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants