-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feature-card): fix feature card broken styles and refactor #12082
fix(feature-card): fix feature card broken styles and refactor #12082
Conversation
Deploy preview created for package Built with commit: b79ed726e09e772aef5db9ffc780e3687a44ed21 |
Deploy preview created for package Built with commit: b79ed726e09e772aef5db9ffc780e3687a44ed21 |
While this would be against content guidance, can we make the component stretch vertically when extremely long content is entered? Perhaps we can use the grid/pseudo-element tricks we did in the caem-tile? |
465a022
into
carbon-design-system:main
Hey there! This issue/pull request was referenced in recently released v2.14.0. |
1 similar comment
Hey there! This issue/pull request was referenced in recently released v2.14.0. |
Related Ticket(s)
ADCMS-6497
Description
The
<c4d-feature-card>
has been broken for some time. This PR is a refactor of the styles to align with the v2 Figma specs.Testing instructions
This ended up being close to a ground-up rewrite of the styles for
<c4d-feature-card>
. The Storybook should be compared with the Figma specs for all spacing, type, colors, interaction states, inverse states, Carbon themes, etc.Some things to note:
Changelog
Changed
<c4d-feature-card>
per the v2 spec