Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(structured-list, pricing-table): correct coloration, spacing & alignment #12101

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fix(structured-list, pricing-table): correct coloration, spacing & alignment #12101

merged 6 commits into from
Nov 12, 2024

Conversation

andy-blum
Copy link
Member

@andy-blum andy-blum commented Nov 11, 2024 •
edited
Loading

Description

Corrects v1->v2 regressions in the structured-list and pricing-table components with cells containging icons.

Current:
Screenshot 2024-11-11 at 9 31 41 AM

Expected:
Screenshot 2024-11-11 at 9 31 12 AM

Changelog

Changed

  • Fixed spacing and alignment bugs
  • Slight reworking of the part attributes

@andy-blum andy-blum requested a review from a team as a code owner November 11, 2024 14:24
@andy-blum andy-blum requested review from m4olivei, bruno-amorim, marcelojcs and Valentin-Sorin-Nicolae and removed request for a team November 11, 2024 14:24
@andy-blum andy-blum added the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Nov 11, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit cbf9470
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/673273f3b280d70008072721
😎 Deploy Preview https://deploy-preview-12101--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/67336d67bd2ef62723f7e3c2
😎 Deploy Preview https://deploy-preview-12101--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

areagan1030
areagan1030 approved these changes Nov 11, 2024
View reviewed changes
Copy link

@areagan1030 areagan1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve "cell with icon" display

@andy-blum
Copy link
Member Author

Looks like the pricing-table is still wrong

https://deploy-preview-12101--ibm-dotcom-web-components.netlify.app/iframe.html?args=&knob-section%20heading=Optional%20section%20heading&knob-number%20of%20columns=3&knob-highlighted%20column=2&knob-highlighted%20label=Featured&knob-col-span-1=&knob-col-span-2=&knob-col-span-3=&knob-col-span-4=&knob-icon-text=lorem%20ipsum&id=experimental-pricing-table--default&viewMode=story

@andy-blum andy-blum changed the base branch from main to release/v2.15.1 November 11, 2024 21:32
@m4olivei m4olivei added Ready to merge Label for the pull requests that are ready to merge and removed Needs design approval PRs on feature requests and new components have to get design approval before merge. labels Nov 12, 2024
@m4olivei
Copy link
Contributor

@andy-blum There are some annoying stylelint issues in the CI 😐

@andy-blum andy-blum added Ready to merge Label for the pull requests that are ready to merge and removed Ready to merge Label for the pull requests that are ready to merge labels Nov 12, 2024
@andy-blum andy-blum merged commit b398375 into release/v2.15.1 Nov 12, 2024
10 of 15 checks passed
@andy-blum andy-blum deleted the fix/pricing-table-icon-text branch November 12, 2024 19:52
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.15.1.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@areagan1030 areagan1030 areagan1030 approved these changes

@m4olivei m4olivei m4olivei approved these changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim bruno-amorim was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@marcelojcs marcelojcs Awaiting requested review from marcelojcs marcelojcs was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae Awaiting requested review from Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy-blum @m4olivei @areagan1030 @ibmdotcom-bot