feat(star-rating): new component #12102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelojcs
requested review from
m4olivei,
bruno-amorim,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m4olivei
requested changes
Nov 12, 2024
packages/web-components/src/components/star-rating/__stories__/star-rating.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/star-rating/__stories__/star-rating.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/star-rating/__stories__/star-rating.stories.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/star-rating/star-rating.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/star-rating/star-rating.ts
Outdated
Show resolved
Hide resolved
…r-ibm-dotcom into migrate/star-rating
|
Pushed a fix for RTL rendering. There's still an RTL bug in the tooltip, but that's an upstream problem carbon-design-system/carbon#18059 |
m4olivei
added
the
Ready to merge
kodiakhq
bot
merged commit dfb0605
into
carbon-design-system:main
20 of 24 checks passed
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
JIRA
Description
Migrates the
star-ratingcomponent fromcarbon-for-aemintocarbon-for-ibmdotcom.Changelog
New
c4d-star-ratingcomponent