-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(masthead-l1): set default active item based on host & pathname #12106
Conversation
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploy preview created for package Built with commit: f3c8852ed857872004bb8027f9a2f486cde5ce10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised. I'm curious about one line in the code (see comment). Feel free to address/ignore and move forward.
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-6689
Description
Modifies the fallback behavior of marking the "active" L1 items.
Note how the L1 behaves on https://www.ibm.com/products/watsonx-orchestrate/ai-agent-for-hr
compared to https://www.ibm.com/products/watsonx-orchestrate/ai-agent-for-hr?lnk=hpUSrc4 (same url, with query params)
Changelog
Changed