Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(masthead-l1): set default active item based on host & pathname #12106

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

andy-blum
Copy link
Member

@andy-blum andy-blum commented Nov 13, 2024

Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-6689

Description

Modifies the fallback behavior of marking the "active" L1 items.

Note how the L1 behaves on https://www.ibm.com/products/watsonx-orchestrate/ai-agent-for-hr
Screenshot 2024-11-13 at 10 04 31 AM

compared to https://www.ibm.com/products/watsonx-orchestrate/ai-agent-for-hr?lnk=hpUSrc4 (same url, with query params)
Screenshot 2024-11-13 at 10 05 12 AM

Changelog

Changed

  • updates L1 active item fallback behavior to ignore query parameters

@andy-blum andy-blum added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Nov 13, 2024
@andy-blum andy-blum requested a review from a team as a code owner November 13, 2024 15:06
@andy-blum andy-blum requested review from m4olivei, bruno-amorim, marcelojcs and Valentin-Sorin-Nicolae and removed request for a team November 13, 2024 15:06
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit f3c8852
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/673cc04cf8b6ec00086da26b
😎 Deploy Preview https://deploy-preview-12106--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit f3c8852
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/673cc04c8b5bf100085eb3fa
😎 Deploy Preview https://deploy-preview-12106--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 13, 2024

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12106/index.html

Built with commit: f3c8852ed857872004bb8027f9a2f486cde5ce10

Copy link
Contributor

@marcelojcs marcelojcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. I'm curious about one line in the code (see comment). Feel free to address/ignore and move forward.

@m4olivei m4olivei added Ready to merge Label for the pull requests that are ready to merge merge.priority_merge_label and removed merge.priority_merge_label labels Nov 19, 2024
@kodiakhq kodiakhq bot merged commit 37166c0 into main Nov 19, 2024
18 of 25 checks passed
@kodiakhq kodiakhq bot deleted the fix/l1-active-indicator branch November 19, 2024 17:37
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants