Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale-search): fix class fields error for inputTimeout #12112

Merged

Conversation

m4olivei
Copy link
Contributor

Related Ticket(s)

Closes #12087 (partially, see also #12088)

Description

Fixes the following error reported when using react wrapped components:

Error: The following properties on element c4d-locale-search will not trigger updates as expected because they are set using class fields: inputTimeout. Native class fields and some compiled output will overwrite accessors used for detecting changes. See https://lit.dev/msg/class-field-shadowing for more information.

Changelog

Changed

  • Declare inputTimeout class property of ThrottledInputMixin as abstract, relying on children to implement.

@m4olivei m4olivei requested a review from a team as a code owner November 19, 2024 14:43
@m4olivei m4olivei requested review from bruno-amorim, marcelojcs, andy-blum and Valentin-Sorin-Nicolae and removed request for a team November 19, 2024 14:43
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 637c30e
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/673cd32ca78c8400086dcbf0
😎 Deploy Preview https://deploy-preview-12112--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 637c30e
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/673cd32cfd11fe0008e4540b
😎 Deploy Preview https://deploy-preview-12112--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Nov 19, 2024
@m4olivei m4olivei closed this Nov 19, 2024
@m4olivei m4olivei reopened this Nov 19, 2024
@m4olivei m4olivei removed the Ready to merge Label for the pull requests that are ready to merge label Nov 19, 2024
@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Nov 19, 2024
@kodiakhq kodiakhq bot merged commit ec54fbe into carbon-design-system:main Nov 19, 2024
20 of 24 checks passed
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React-wrapped components]: Issues with class fields
2 participants