fix(leadspace): in storybook adding long copy to copy knob led to button being clipped away #12117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-amorim
requested review from
m4olivei,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andy-blum
requested changes
Nov 21, 2024
|
@andy-blum This latest commit will address your last comment. Thank you! |
m4olivei
requested changes
Nov 22, 2024
There was a problem hiding this comment.
I'm seeing a visual regression here for the default values. Most obvious in Super. Comparing current v2 to the deploy preview here:
Monosnap.screencast.2024-11-22.11-36-35.mp4
As a sidenote, I was surprised to realize that the Leadspace stories aren't represented in Percy.
andy-blum
approved these changes
Nov 22, 2024
m4olivei
approved these changes
Nov 22, 2024
m4olivei
added
the
Ready to merge
|
Closes #12114 |
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-6827
Description
Adding long text to the leadspace copy knob leads to clipping the text & CTAs.
Issue:
Fixed:
NOTE
There's an apparent bug in all heading/title knobs in all components, when you try to modify it, we get the below error.
I've been trying to debug this error, but with @m4olivei 's help, we found out it's an issue that's been sitting there for a while now, so It would just be very time consuming for the tiny fix that was the original scope of this ticket