Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link-list): v2 style regressions #12125

Merged
merged 17 commits into from
Dec 7, 2024
Merged

Conversation

andy-blum
Copy link
Member

Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-6920
https://jsw.ibm.com/browse/ADCMS-6890

Description

Fixes defects in link-list that deviate from the design specs. Additionally adds new story & knobs

Changelog

Changed

  • Fixes style bugs in link-list & link-list-item

@andy-blum andy-blum requested a review from a team as a code owner November 26, 2024 20:22
@andy-blum andy-blum requested review from m4olivei, bruno-amorim, marcelojcs and Valentin-Sorin-Nicolae and removed request for a team November 26, 2024 20:23
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 5e6d156
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6753c52182d4310008c218a1
😎 Deploy Preview https://deploy-preview-12125--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 5e31fe2
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6750b476c9a5bd000866840f
😎 Deploy Preview https://deploy-preview-12125--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, looks like we have some regressions here:

https://deploy-preview-12125--ibm-dotcom-web-components.netlify.app/?path=/story/components-link-list--end

image

Also looks like a legit fail on the e2e tests.

@m4olivei
Copy link
Contributor

Ok, odd. When you initially load the page, <c4d-link-list-item> are used as children of <c4d-link-list>. When you change the CTA type (cta-type) knob, it rerenders the story with <c4d-link-list-item-cta> components 🤔

@m4olivei m4olivei self-requested a review November 28, 2024 21:53
@andy-blum andy-blum added adopter: AEM used when component or pattern will be used by this adopter priority: high and removed adopter: AEM used when component or pattern will be used by this adopter labels Dec 3, 2024
@andy-blum andy-blum changed the base branch from main to release/v2.16.0 December 5, 2024 13:14
@m4olivei m4olivei force-pushed the fix/link-list-alignment branch from 5e31fe2 to c3bcb75 Compare December 5, 2024 18:15
@andy-blum andy-blum merged commit b400091 into release/v2.16.0 Dec 7, 2024
18 checks passed
@andy-blum andy-blum deleted the fix/link-list-alignment branch December 7, 2024 04:07
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

1 similar comment
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants