Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card-group): set min height to content #12128

Merged

Conversation

marcelojcs
Copy link
Contributor

@marcelojcs marcelojcs commented Nov 27, 2024

Related Ticket(s)

ADCMS-6840

Description

Adding min height to card-group component to ensure the elements have the correct height.

Changelog

New
Adding min height to card-group component to ensure the elements have the correct height.

@marcelojcs marcelojcs requested a review from a team as a code owner November 27, 2024 16:43
@marcelojcs marcelojcs requested review from m4olivei, bruno-amorim, andy-blum and Valentin-Sorin-Nicolae and removed request for a team November 27, 2024 16:43
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 87dae3d
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/674f56ee314a8e000842fd14
😎 Deploy Preview https://deploy-preview-12128--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 87dae3d
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/674f56ee4650b60008b6d1e5
😎 Deploy Preview https://deploy-preview-12128--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andy-blum andy-blum requested a review from m4olivei December 2, 2024 21:25
@andy-blum andy-blum added adopter: AEM used when component or pattern will be used by this adopter priority: high and removed adopter: AEM used when component or pattern will be used by this adopter labels Dec 3, 2024
@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Dec 3, 2024
@kodiakhq kodiakhq bot merged commit 8dc1099 into carbon-design-system:main Dec 3, 2024
18 of 19 checks passed
deathcave pushed a commit to deathcave/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2024
### Related Ticket(s)

[JIRA](https://jsw.ibm.com/browse/ADCMS-6840)

### Description

Adding min height to card-group component to ensure the elements have the correct height.

### Changelog

**New**
Adding min height to card-group component to ensure the elements have the correct height.
andy-blum pushed a commit that referenced this pull request Dec 4, 2024
### Related Ticket(s)

[JIRA](https://jsw.ibm.com/browse/ADCMS-6840)

### Description

Adding min height to card-group component to ensure the elements have the correct height.

### Changelog

**New**
Adding min height to card-group component to ensure the elements have the correct height.
@andy-blum andy-blum mentioned this pull request Dec 4, 2024
kodiakhq bot pushed a commit that referenced this pull request Dec 5, 2024
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants