-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(card-group): set min height to content #12128
Merged
kodiakhq
merged 17 commits into
carbon-design-system:main
from
marcelojcs:fix/card-group_wrong-styles
Dec 3, 2024
Merged
fix(card-group): set min height to content #12128
kodiakhq
merged 17 commits into
carbon-design-system:main
from
marcelojcs:fix/card-group_wrong-styles
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-ibm-dotcom into fix/card-group_wrong-styles
…arbon-for-ibm-dotcom into fix/card-group_wrong-styles
marcelojcs
requested review from
m4olivei,
bruno-amorim,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
November 27, 2024 16:43
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m4olivei
requested changes
Nov 27, 2024
…-for-ibm-dotcom into fix/card-group_wrong-styles
…arbon-for-ibm-dotcom into fix/card-group_wrong-styles
…-for-ibm-dotcom into fix/card-group_wrong-styles
andy-blum
added
adopter: AEM
used when component or pattern will be used by this adopter
priority: high
and removed
adopter: AEM
used when component or pattern will be used by this adopter
labels
Dec 3, 2024
m4olivei
approved these changes
Dec 3, 2024
m4olivei
added
the
Ready to merge
Label for the pull requests that are ready to merge
label
Dec 3, 2024
kodiakhq
bot
merged commit Dec 3, 2024
8dc1099
into
carbon-design-system:main
18 of 19 checks passed
deathcave
pushed a commit
to deathcave/carbon-for-ibm-dotcom
that referenced
this pull request
Dec 4, 2024
### Related Ticket(s) [JIRA](https://jsw.ibm.com/browse/ADCMS-6840) ### Description Adding min height to card-group component to ensure the elements have the correct height. ### Changelog **New** Adding min height to card-group component to ensure the elements have the correct height.
andy-blum
pushed a commit
that referenced
this pull request
Dec 4, 2024
### Related Ticket(s) [JIRA](https://jsw.ibm.com/browse/ADCMS-6840) ### Description Adding min height to card-group component to ensure the elements have the correct height. ### Changelog **New** Adding min height to card-group component to ensure the elements have the correct height.
Merged
Hey there! This issue/pull request was referenced in recently released v2.16.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-6840
Description
Adding min height to card-group component to ensure the elements have the correct height.
Changelog
New
Adding min height to card-group component to ensure the elements have the correct height.