Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): push the footer to the bottom of the card consistently #12137

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Dec 2, 2024

Related Ticket(s)

ADCMS-7121
ADCMS-7158

Description

Under certain conditions, the footer of a card, especially within a group, might not stick to the end of the card as intended. This fixes it so that the card footer is always at the end of the card.

Changelog

Changed

  • Force the footer of cards to be at the end, corrects an issue with Content Group Cards

@m4olivei m4olivei requested a review from a team as a code owner December 2, 2024 16:47
@m4olivei m4olivei requested review from bruno-amorim, marcelojcs, andy-blum and Valentin-Sorin-Nicolae and removed request for a team December 2, 2024 16:47
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit cb7e54c
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6753b54fc331250008decd25
😎 Deploy Preview https://deploy-preview-12137--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 532e5a0
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/674ef6b62a43db00085b0a5d
😎 Deploy Preview https://deploy-preview-12137--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good to me...

@andy-blum andy-blum added adopter: AEM used when component or pattern will be used by this adopter priority: high and removed adopter: AEM used when component or pattern will be used by this adopter labels Dec 3, 2024
@andy-blum andy-blum changed the base branch from main to release/v2.16.0 December 5, 2024 13:13
@m4olivei m4olivei force-pushed the fix/card-wraper-div-height branch from 532e5a0 to 350838d Compare December 5, 2024 18:06
@m4olivei m4olivei requested a review from andy-blum December 6, 2024 21:51
@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Dec 7, 2024
@kodiakhq kodiakhq bot merged commit e817962 into carbon-design-system:release/v2.16.0 Dec 7, 2024
17 of 18 checks passed
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants