fix(background-media): avoid potential VPC setup race

[andy-blum]

Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-7249

Description

Modifies component logic to avoid a possible race condition. Previously we assumed the background media component was setting up after the video player container had created its video player child.

Changelog

Changed

• avoid possible race condition in with background videos

[netlify]

✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name	Link
🔨 Latest commit	6fbf900
🔍 Latest deploy log	https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6759a52156a001000843486b
😎 Deploy Preview	https://deploy-preview-12158--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name	Link
🔨 Latest commit	6fbf900
🔍 Latest deploy log	https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6759a5211f6faf00081a1477
😎 Deploy Preview	https://deploy-preview-12158--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name	Link
🔨 Latest commit	6014f37
🔍 Latest deploy log	https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/675a2e1b1e6263000734b8ce
😎 Deploy Preview	https://deploy-preview-12158--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[m4olivei]

Small nit pick. Looks like we can clean up an unused class property. Otherwise looking good. The changes make logical sense, its cleaner and more direct to go through the video player container rather than the video player.

I wasn't able to reproduce the reported issue in AEM on my local, but using these changes in AEM did not cause any regressions for me, working as expected there.

Feel free to address the nit or not and move forward. Nice work.

[m4olivei]

Wait sorry, too quick.

In Storybook, (and in local AEM), I'm not seeing the button toggle between play / pause visually along with the video playback itself. Its also not remembering auto-play preferences 😕 .

[m4olivei]

We're still not getting the autoplay preference behavior happening for bg video. Thats still a regression we should fix. I'm seeing that with the updated approach here, the c4d-background-video-prefers-autoplay localstorage key does not get set, compared to the latest rc3 Storybook instance where it does and is respected on a reload of the Story.

[m4olivei]

Looks good now! Thanks for the quick fixes.

[github-actions]

Hey there! This issue/pull request was referenced in recently released v2.16.0.