fix(link-with-icon): fix icon placement

[m4olivei]

Related Ticket(s)

ADCMS-7258

Description

This corrects a bad prefix conversion from v1 to v2 that meant that the necessary styles required to correctly reflect the icon-placement="left" on a <c4d-link-with-icon> component were not present. Note that the way Storybook knobs work was hiding this issue in the Link with Icon story. The bug can be reproduced by going to the Link with icon story in the v2 Storybook, setting "Icon Position" to left, then opening in a new tab. Test in the deploy preview in the same way to ensure the bug is fixed.

Testing instructions

• Open the Link with Icon > Default story
• Set the "Icon Position" knob to left
• Open in a new tab
• Icon should now appear as expected
• Also go through the Footer and Locale Modal stories to check the reported link icon is in the right spot.

Changelog

Changed

• Fixed left icon placement in Link with icon component

[netlify]

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name	Link
🔨 Latest commit	8516c52
🔍 Latest deploy log	https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6759b66a1dab7f00086bd009
😎 Deploy Preview	https://deploy-preview-12159--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[andy-blum]

This also fixes the bug seen in the current storybook where changing the icon position and then adding more items resulted in mixed placements.

[github-actions]

Hey there! This issue/pull request was referenced in recently released v2.16.0.