-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up copy #1515
fix: clean up copy #1515
Conversation
- make descriptions consistent across site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good from your goal of streamlining content. I had a few comments and suggestions but not any specific corrections, the biggest one being around the design kit description. I'll go ahead and greenlight it though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is a great clean up. Thanks Matt!
I left notes on some content I'd like to revert back to, each of which were drafted with stakeholder and user feedback. Namely:
- Add component examples back in
- Add examples of Design Kit tools back in
- Add code tags/highlights back in for the How Carbon Works page.
- not carbon platform squad
@carbon-design-system/carbon-platform-designers can I get another review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it looks good to me!
❗ The commits in this PR will result in the following version changes: 🐛 PATCH release: |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Content cleanup after reading through primary platform description pages.
Changelog
New
Changed
Home page:
e.g.
This also made the description lengths more consistent to prevent widows at common breakpoints.Schema page:
How Carbon works page:
Library design kits page:
Removed
Testing / reviewing
Run locally to see the updated pages.