This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Replace -S
with -P
in npm install
instruction
#634
Labels
Airtable Done
Corresponding record created in Airtable
dev
Needs some dev work
documentation
Improvements or additions to documentation
Milestone
When I follow the instructions in the top-level README file to install the component library:
npm install -S carbon-web-components carbon-components
I find that it leads to a peer dependency conflict:
Looking at the change history of the project's package.json file, I see that the version of
carbon-components
library dependency is locked down (using the tilde version specifier) and is periodically bumped up. Presumably somebody is carefully testing that thecarbon-web-components
library is in fact compatible with the newer version of thecarbon-components
library. But is it truly necessary to lock down versions that tightly? If it is, people should be told to specify the versions explicitly in thenpm install
comand:npm install --save carbon-components@10.32.0 carbon-web-components@1.13.1
That works, but specifying versions in this way is not something that I can recall seeing before. It seems like something outside of best practices.
Also: The use of the "-S" option in the README's npm command example no longer works. Would be good to change:
npm install -S carbon-web-components carbon-components lit-html lit-element
to:
npm install --save carbon-web-components carbon-components lit-html lit-element
Originally posted by @TrentBrown in #557 (comment)
The text was updated successfully, but these errors were encountered: