Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update check emoji to carbon icon on tile style page #2497

Closed
kingtraceyj opened this issue Aug 16, 2021 · 3 comments · Fixed by #3124
Closed

update check emoji to carbon icon on tile style page #2497

kingtraceyj opened this issue Aug 16, 2021 · 3 comments · Fixed by #3124
Assignees
@francinelucca
Labels
component: tile good first issue 👋 Used to GitHub to elevate contribution opportunities type: bug 🐛 type: docs 📖

Comments

@kingtraceyj
Copy link
Member

Proportions for grid table on tile component's style page should be using carbon icons rather then the emoji checks check ✅

image
@jnm2377 jnm2377 added the good first issue 👋 Used to GitHub to elevate contribution opportunities label Aug 15, 2022
@jnm2377
Copy link
Contributor

jnm2377 commented Aug 15, 2022

@kingtraceyj which of the checkmark icons should it use?

Screen Shot 2022-08-15 at 11 59 45 AM

@kingtraceyj
Copy link
Member Author

@jnm2377 let's use <CheckmarkOutline /> in gray 100

@francinelucca francinelucca self-assigned this Aug 22, 2022
francinelucca added a commit to francinelucca/carbon-website that referenced this issue Aug 24, 2022
@francinelucca
fix(tile): replace check emoji with carbon icon
5f5d5cd 
Closes carbon-design-system#2497
@francinelucca francinelucca mentioned this issue Aug 29, 2022
Merged
@kingtraceyj
Copy link
Member Author

@francinelucca we are going with checkmark in icon-primary
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francinelucca francinelucca

Labels
component: tile good first issue 👋 Used to GitHub to elevate contribution opportunities type: bug 🐛 type: docs 📖
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flucca/fix/tile component style page check change francinelucca/carbon-website
3 participants
@kingtraceyj @jnm2377 @francinelucca