fix: website button style bugs #3639
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
requested review from
tw15egan,
francinelucca,
aubrey-oneal and
laurenmrice
| // Header icon style fix needed because the Carbon website is on a | ||
| // newer version of Carbon vs. the Gatsby theme | ||
| // If the Gatsby theme is updated to use latest Carbon, this | ||
| // shouldn't be needed |
There was a problem hiding this comment.
It looks like 3.1.2 was just released for gatsby-theme-carbon which bumps the @carbon version to 1.32.0. Should we try updating that and see if the issue resolves itself?
There was a problem hiding this comment.
Just checked, both issues are still there 😓 - not sure why this issue isn't showing up on Gatsby
There was a problem hiding this comment.
- The tooltip should be set to align
top-rightto avoid the off centering and the tooltip needs to be 4px above the overflow menu icon button instead of overlapping with the button.
- When the overflow menu is open, the background of the overflow menu icon button should be the same color as the row items.
|
@tw15egan The original bugs seem to be gone on the website since the latest update to @laurenmrice I'll open a new PR to fix the issues in your comment. I think those are unrelated to whatever else was happening. |
|
Oh okay gotcha, thanks @alisonjoseph |
Closes #3638
Closes #3637
Changelog
Add style override for switcher / switcher close icon button
Add style to fix overflow menu on color page