Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: website button style bugs #3639

Closed
wants to merge 1 commit into from
Closed

fix: website button style bugs #3639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/components/ColorTokenTable/color-token-table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@
.color-token-value .cds--overflow-menu {
margin-left: $spacing-03;
margin-top: -$spacing-03;
padding-block-start: 0;
background-color: $layer-01;

&:hover {
background-color: $layer-hover;
}
}

.color-token-value .cds--overflow-menu-options {
Expand Down
8 changes: 8 additions & 0 deletions src/styles/_overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,11 @@
[class^='FourOhFour-module--link']:before {
color: $text-inverse !important;
}

// Header icon style fix needed because the Carbon website is on a
// newer version of Carbon vs. the Gatsby theme
// If the Gatsby theme is updated to use latest Carbon, this
// shouldn't be needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 3.1.2 was just released for gatsby-theme-carbon which bumps the @carbon version to 1.32.0. Should we try updating that and see if the issue resolves itself?

Copy link
Member Author

@alisonjoseph alisonjoseph Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, both issues are still there 😓 - not sure why this issue isn't showing up on Gatsby

button[class*='Header-module--switcher-button'] {
padding-block-start: 0;
}