Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Link usage updates #1138

Merged

Conversation

jillianhowarth
Copy link
Contributor

Usage guidance updates with new documentation template for the link component.

@netlify
Copy link

netlify bot commented Apr 28, 2020

Deploy preview for carbon-website ready!

Built with commit 34b0758

https://deploy-preview-1138--carbon-website.netlify.app

@vercel
Copy link

vercel bot commented Apr 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/o3ypfg84b
✅ Preview: https://carbon-website-git-fork-jillianhowarth-link-usage-docs.carbon-design-system.now.sh

@jillianhowarth jillianhowarth marked this pull request as ready for review May 7, 2020 16:26
@jillianhowarth jillianhowarth requested review from a team May 7, 2020 16:26
@jillianhowarth jillianhowarth requested a review from a team as a code owner May 7, 2020 16:26
@jillianhowarth jillianhowarth requested review from connor-leech, jnm2377 and andreancardona and removed request for a team May 7, 2020 16:26
@ghost ghost requested review from asudoh and emyarod and removed request for a team May 7, 2020 16:26
@jillianhowarth jillianhowarth requested review from janchild and a team and removed request for connor-leech and asudoh May 7, 2020 16:26
@ghost ghost requested review from joshblack and removed request for a team May 7, 2020 16:26
@jillianhowarth jillianhowarth removed the request for review from joshblack May 7, 2020 16:26
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 8, 2020 13:37 Inactive
jillianhowarth and others added 2 commits May 8, 2020 08:37
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 8, 2020 13:37 Inactive
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 8, 2020 13:38 Inactive
jillianhowarth and others added 2 commits May 8, 2020 08:39
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just a few corrections

src/pages/components/link/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/link/usage.mdx Outdated Show resolved Hide resolved
Co-authored-by: emyarod <emyarod@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 8, 2020 15:27 Inactive
Co-authored-by: emyarod <emyarod@users.noreply.github.com>
src/pages/components/link/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/link/usage.mdx Outdated Show resolved Hide resolved
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 8, 2020 19:59 Inactive
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview May 8, 2020 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 20:03 Inactive
Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂 Fantastic!

@jillianhowarth jillianhowarth merged commit 5682bca into carbon-design-system:master May 8, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* Docs: Link usage updates

* docs: screen reader copy

* Docs: typo

* Docs: update inline image

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: emyarod <emyarod@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: emyarod <emyarod@users.noreply.github.com>

* Docs: type update

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Docs: updates

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: emyarod <emyarod@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* Docs: Link usage updates

* docs: screen reader copy

* Docs: typo

* Docs: update inline image

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: emyarod <emyarod@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: emyarod <emyarod@users.noreply.github.com>

* Docs: type update

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Update src/pages/components/link/usage.mdx

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

* Docs: updates

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: emyarod <emyarod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants