-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(file-uploader): usage content updates #1527
docs(file-uploader): usage content updates #1527
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/ezd1zbfqo |
6cfacd4
to
a61f9f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome @laurenmrice! Just a few minor changes 🙂
b274557
to
5bbfc62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg super cute. Just a couple of comments!
For these guys, I think we're going italic on the "large, medium and small"
For this guy, the primary button in that panel should be on the right, the secondary button would be a Gray 60 and the stroke between would be a gray 100.
I might try dashing the magenta outline here so it's just like the drag and drop outline
Little green check mark icon will have a Black check mark inside of it (not white) for contrast accessibility. One other question, this looks great, but are those buttons on grid (two columns?)
Otherwise awesome!
…rice/carbon-website into file-uploader-usage-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes to the reader controls
🏄 ♿
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the quick tab update, perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @laurenmrice!
* update: content * update: images * content edit * update: edit content * image column edit * Update: content edit * update: content * update: images * content edit * update: edit content * image column edit * Update: content edit * image review edits * content edit review * image update Co-authored-by: TJ Egan <tw15egan@gmail.com>
* update: content * update: images * content edit * update: edit content * image column edit * Update: content edit * update: content * update: images * content edit * update: edit content * image column edit * Update: content edit * image review edits * content edit review * image update Co-authored-by: TJ Egan <tw15egan@gmail.com>
Closes #1403
Add new images and update content with the new content template
New