Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: new pattern templates #2055

Merged
merged 4 commits into from
Dec 19, 2020
Merged

docs: new pattern templates #2055

merged 4 commits into from
Dec 19, 2020

Conversation

janchild
Copy link
Contributor

This PR updates the existing single pattern template with two types of pattern templates--one for single variant, and one for multiple variants.

The pattern templates themselves have undergone significant revision to capture what we learned through both the pattern development process and the component usage guidance development process.

@janchild janchild self-assigned this Dec 18, 2020
@janchild janchild requested a review from a team December 18, 2020 17:40
@janchild janchild requested a review from a team as a code owner December 18, 2020 17:40
@vercel
Copy link

vercel bot commented Dec 18, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/q527z5u83
✅ Preview: https://carbondesignsystem-git-docs-new-pattern-templates.carbon-design-system.now.sh

alisonjoseph
alisonjoseph approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might want to add line breaks between the anchor links in the code snippet.

@janchild
Copy link
Contributor Author

Looks good. Might want to add line breaks between the anchor links in the code snippet.

Thanks, @alisonjoseph. I did this by adding two spaces at the end of each line. It did the trick!

@janchild janchild linked an issue Dec 19, 2020 that may be closed by this pull request
[docs] add new template for patterns with multiple types to site #2018
Closed
@kodiakhq kodiakhq bot merged commit 409aeae into carbon-design-system:master Dec 19, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@janchild @natashadecoste
docs: new pattern templates (carbon-design-system#2055)
076145c 
* docs: new pattern templates

* docs: line break fix for anchor links

* fix line breaks

* docs: language alignment - patterns and components
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@janchild @natashadecoste
docs: new pattern templates (carbon-design-system#2055)
3c025f3 
* docs: new pattern templates

* docs: line break fix for anchor links

* fix line breaks

* docs: language alignment - patterns and components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@jeanservaas jeanservaas jeanservaas approved these changes

@jillianhowarth jillianhowarth Awaiting requested review from jillianhowarth

@emyarod emyarod Awaiting requested review from emyarod

@dakahn dakahn Awaiting requested review from dakahn

Assignees

@janchild janchild

Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] add new template for patterns with multiple types to site
3 participants
@janchild @alisonjoseph @jeanservaas