Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website to v11, @carbon/react #2764

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Mar 3, 2022

This PR updates the website to use the newest version of gatsby, gatsby-theme-carbon, and related carbon dependencies for v11

Changelog

Changed

  • update various dependencies
  • update sass token usage to reflect changes made in v11

@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/HPqBbBaRjQ4RZeCQCxAsbiL5cH87
✅ Preview: https://carbondesignsystem-git-fork-tay1orj-bcf273-carbon-design-system.vercel.app

@tay1orjones
Copy link
Member Author

@sstrubberg @alisonjoseph - @aledavila and I did not encounter the pictogram library and icon library issues you encountered in #2689 🎉

@tay1orjones tay1orjones marked this pull request as ready for review March 7, 2022 22:16
@tay1orjones tay1orjones requested review from theiliad and a team as code owners March 7, 2022 22:16
@tay1orjones
Copy link
Member Author

I put a lot of reviewers on here - the more eyes the better! 👀 We've stepped through nearly every page and things seem to look good, but a thorough review is appreciated 🙏

@alisonjoseph
Copy link
Member

@sstrubberg @alisonjoseph - @aledavila and I did not encounter the pictogram library and icon library issues you encountered in #2689 🎉

Awesome! Will take a look through tomorrow 💯

@tay1orjones
Copy link
Member Author

@alisonjoseph Thanks! Just pushed up a couple commits that should fix all those items.

@theiliad Yeah, it looks like charts is using bx prefixed classes. Once charts updates to use the new cds prefix it should be fixed. Let me know if I can help!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (other than the charts issue Elliad pointed out) 👍

@tay1orjones
Copy link
Member Author

Note that the grid demo page is totally borked. I can't fix it until carbon-design-system/carbon#10934 lands and is published (I'll cut a patch release for it ASAP).

The demo grids have to be scoped with a prefix, which I can't do without having the grid code included twice. Including it twice breaks other things due to it being farther down in the cascade.

Similar thing with the charts fix - it's reliant on updating an external dep.

Since this is merging into the v11 branch, I'd like to get the bulk of these changes in and carry these two issues forward. I'll issue follow-up PRs for them individually.

@tw15egan
Copy link
Member

Screen Shot 2022-03-10 at 1 06 36 PM

I believe we need to port over this fix

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed a bunch of pages and didn't see any breaking bugs. Since this is going to the v11 branch, I'm good with it 👍🏻 ✅

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 11, 2022

Just some things I noticed:

  • Feedback dialog styles are off. But this may be something we missed in GTC. I'm unsure.

Screen Shot 2022-03-10 at 1 47 47 PM

(how it should be)
Screen Shot 2022-03-10 at 1 48 07 PM

  • In the homepage, the feedback dialog can't be opened at all, and it's opacity is less than 1 for some reason.

Screen Shot 2022-03-10 at 1 48 39 PM

  • some of the codesnippets that have file structures are no longer aligned. This feels nitpicky, sorry. But they're working correctly in the current site, so just wanna make sure we capture that somewhere to fix either now or later.

Screen Shot 2022-03-10 at 2 40 21 PM

Screen Shot 2022-03-10 at 2 00 09 PM

  • Icon page and Pictogram page search bar is too small, and the dropdown has a dark line at the bottom now. The search bar sizing makes it so that you can see some of the content when you're scrolling.

Screen Shot 2022-03-10 at 2 47 19 PM

(when scrolling)
Screen Shot 2022-03-10 at 2 47 42 PM

(how it should be)
Screen Shot 2022-03-10 at 2 47 29 PM

@laurenmrice laurenmrice self-requested a review March 11, 2022 17:03
@laurenmrice
Copy link
Member

I noticed a couple of things:

Community assets —> Component index page

  • The Tags are getting a background color behind them and the tooltips on hover have been enlarged.

Screen Shot 2022-03-11 at 11 03 53 AM

Guidelines —> Color page (Usage tab)

  • A drop shadow has been put underneath the content switcher. A drop shadow shouldn’t appear until the page scrolls and content switcher is on top of the table.

Screen Shot 2022-03-11 at 11 07 16 AM

Guidelines —> Icons and Pictograms page (Library tab)

  • Tooltips have disappeared from the hoverable icon buttons to download and copy code.

Screen Shot 2022-03-11 at 11 09 35 AM

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 11, 2022

A few more things:

  • this actually seems like it might be an existing issue... when you're on the Community assets > Component index > Contribute a component tab, and you click the Next tile at the bottom of the page, it actually takes you to the previous as in the next and previous tile are both the same href.

Screen Shot 2022-03-11 at 11 18 08 AM

  • the data viz color palette component no longer has a visible focus state in the content switcher, neither when you click or tab thru

(this PR)
Screen Shot 2022-03-11 at 11 19 46 AM

(how it should be)
Screen Shot 2022-03-11 at 11 19 53 AM

@tay1orjones tay1orjones mentioned this pull request Mar 11, 2022
12 tasks
@tay1orjones
Copy link
Member Author

We're going to continue to address the remaining issues (and any more we find!) in the next sprint. In the meantime I'd like to continue to have other folks work on documentation and migration updates that require the v11 styles be in next.

So I'm going to merge this as is so we don't impede the other workstreams happening in parallel. All the follow-up items outlined above to be fixed next sprint have been documented in #2785

If any new issues are encountered, update that issue. It can be our living list of items to address for now.

@theiliad
Copy link
Member

@tay1orjones, just cut out v0.55.0 in charts. Using that should solve the charting issues, hopefully...

@tay1orjones
Copy link
Member Author

@theiliad Thank you! That fixes the chart pages 🎉

@tay1orjones tay1orjones merged commit c26f32b into carbon-design-system:v11 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants