-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website to v11, @carbon/react #2764
Update website to v11, @carbon/react #2764
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/HPqBbBaRjQ4RZeCQCxAsbiL5cH87 |
@sstrubberg @alisonjoseph - @aledavila and I did not encounter the pictogram library and icon library issues you encountered in #2689 🎉 |
I put a lot of reviewers on here - the more eyes the better! 👀 We've stepped through nearly every page and things seem to look good, but a thorough review is appreciated 🙏 |
Awesome! Will take a look through tomorrow 💯 |
@alisonjoseph Thanks! Just pushed up a couple commits that should fix all those items. @theiliad Yeah, it looks like charts is using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (other than the charts issue Elliad pointed out) 👍
Note that the grid demo page is totally borked. I can't fix it until carbon-design-system/carbon#10934 lands and is published (I'll cut a patch release for it ASAP). The demo grids have to be scoped with a prefix, which I can't do without having the grid code included twice. Including it twice breaks other things due to it being farther down in the cascade. Similar thing with the charts fix - it's reliant on updating an external dep. Since this is merging into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed a bunch of pages and didn't see any breaking bugs. Since this is going to the v11 branch, I'm good with it 👍🏻 ✅
Just some things I noticed:
|
I noticed a couple of things: Community assets —> Component index page
Guidelines —> Color page (Usage tab)
Guidelines —> Icons and Pictograms page (Library tab)
|
A few more things:
|
We're going to continue to address the remaining issues (and any more we find!) in the next sprint. In the meantime I'd like to continue to have other folks work on documentation and migration updates that require the v11 styles be in So I'm going to merge this as is so we don't impede the other workstreams happening in parallel. All the follow-up items outlined above to be fixed next sprint have been documented in #2785 If any new issues are encountered, update that issue. It can be our living list of items to address for now. |
@tay1orjones, just cut out v |
…on-website into update-gatsby-theme-v11
@theiliad Thank you! That fixes the chart pages 🎉 |
This PR updates the website to use the newest version of
gatsby
,gatsby-theme-carbon
, and related carbon dependencies for v11Changelog
Changed