Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(livedemo): add left border #2880

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

tay1orjones
Copy link
Member

This updates all live demo preview containers to now have a left border to avoid the issue described in carbon-design-system/carbon#10889 (comment)

Changelog

Changed

  • add back the left border to the live demo preview container

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/54qUtNXEDH6m7VkaZJ4T1A9pxJxk
✅ Preview: https://carbondesignsystem-git-fork-tay1orj-f6649e-carbon-design-system.vercel.app

@tay1orjones tay1orjones self-assigned this Apr 11, 2022
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its doing a weird tapper at the corner. Can we get those two border ends squarely meet?

image

@aagonzales
Copy link
Member

Also I think we probably need to border to go all the way across the top as well. Otherwise there's a gap there with the Gray 10 theme

image

@aagonzales
Copy link
Member

@tay1orjones so I thought this was a intentional design decision at some point but maybe was just bug. Instead of the line board, these demos used to have this 8px white boarder. I talked to the other designers and seems like this change wasn't intentional. Can we actually just bring that back?

Its on the v10 demos

@tay1orjones
Copy link
Member Author

@aagonzales Ah! That explains a ton 😅 I see now that we updated the border to use the new tokens, so it's no longer a fixed value but changes with the theme. I'll push an update to fix.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kodiakhq kodiakhq bot merged commit 923a339 into carbon-design-system:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants