-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(livedemo): add left border #2880
fix(livedemo): add left border #2880
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/54qUtNXEDH6m7VkaZJ4T1A9pxJxk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tay1orjones so I thought this was a intentional design decision at some point but maybe was just bug. Instead of the line board, these demos used to have this 8px white boarder. I talked to the other designers and seems like this change wasn't intentional. Can we actually just bring that back? Its on the v10 demos |
@aagonzales Ah! That explains a ton 😅 I see now that we updated the border to use the new tokens, so it's no longer a fixed value but changes with the theme. I'll push an update to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This updates all live demo preview containers to now have a left border to avoid the issue described in carbon-design-system/carbon#10889 (comment)
Changelog
Changed