Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add content for popover #2947

Merged

Conversation

joshblack
Copy link
Contributor

Closes #2474
Closes #2487
Closes carbon-design-system/carbon#10974

This PR adds in content updates for the popover component pages. It includes a live demo for these pages and adds in a code page.

Changelog

New

  • Add code page for popover with live demo and links

Changed

  • Add live demo to component usage page for popover
  • Update component demo to explicitly set props to false

Removed

@joshblack joshblack requested review from a team as code owners May 19, 2022 16:57
@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview May 24, 2022 at 3:24PM (UTC)

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!! 🔥 🔥 🔥

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kodiakhq kodiakhq bot merged commit 64af1b6 into carbon-design-system:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants