docs: form and button guidance updates #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
approved these changes
Sep 5, 2023
|
@thyhmdo or @jeanservaas, when you have some time this sprint can you review this PR? Thank you! |
andreancardona
approved these changes
Sep 27, 2023
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3546
Closes #3578
Changelog
Note, some of the images aren't updating in the preview so just check them in the "file changed" tab. This doesn't include all the content enhancement we wanted to do but it at least corrects the obviously wrong rules.
Changed
/patterns/forms-pattern/#buttons
/components/form