docs: Vertical dividers doc update (Dropdown family) #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-jacob
requested review from
alisonjoseph,
tw15egan and
Kritvi-bhatia17
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
alisonjoseph
approved these changes
Feb 15, 2024
src/pages/components/dropdown/images/usage-combobox-vertical-divider-do-2.png
Outdated
Show resolved
Hide resolved
Kritvi-bhatia17
requested changes
Feb 15, 2024
|
I have read the DCO document and I hereby sign the DCO. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Kritvi-bhatia17
approved these changes
Feb 21, 2024
laurenmrice
requested changes
Feb 27, 2024
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
laurenmrice
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Looking great! ✨Just two things:
Usage tab
- The set of default and fluid images under the Multiselect > Filtering section (and right before the Combo box section) look like they have some inconsistencies. I would just align on the following things for both images.
- The Default image has the text "Data" with a typing line indicator in the fields and has a hand cursor on the selected option in the menu.
- The Fluid image only has the text "Data" in the first half of the image when the menu is open and not in the bottom half when the menu is closed. The typing line indicator is also not present in the fluid image and there is no hand cursor on the selected option.
Updated spacing information for vertical dividers in input fields.
laurenmrice
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3865
Figma Ref File