-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Vertical dividers doc update (Dropdown family) #3916
docs: Vertical dividers doc update (Dropdown family) #3916
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DCO Assistant Lite bot All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
src/pages/components/dropdown/images/usage-combobox-vertical-divider-do-2.png
Outdated
Show resolved
Hide resolved
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! Amazing work Alina 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Alina! Just some minor typos
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! ✨Just two things:
Usage tab
- The set of default and fluid images under the Multiselect > Filtering section (and right before the Combo box section) look like they have some inconsistencies. I would just align on the following things for both images.
- The Default image has the text "Data" with a typing line indicator in the fields and has a hand cursor on the selected option in the menu.
- The Fluid image only has the text "Data" in the first half of the image when the menu is open and not in the bottom half when the menu is closed. The typing line indicator is also not present in the fluid image and there is no hand cursor on the selected option.
Updated spacing information for vertical dividers in input fields.
Closes #3865
Figma Ref File