-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update progress indicator usage tab #3924
docs: update progress indicator usage tab #3924
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @aubrey-oneal |
Hey @guidari I put up a WIP PR which is why you're seeing missing content. I still need to work on the Placement imagery but I'd like to request a first review from our designers. One tricky thing was naming the progress states and I'm open to feedback on that. It's tricky because the states implied in the style tab have a mismatch with the icon names they use. I.e. 'Current' state uses the 'Incomplete' icon and 'Incomplete' state uses the 'Not started' icon. |
@aubrey-oneal Ohh okay! |
Thanks for the offer @guidari! I think for this PR our scope is going to be just getting docs up for the component as it is and we'll make some issues for potential future component updates! |
src/pages/components/progress-indicator/images/progress-indicator-usage-2.png
Outdated
Show resolved
Hide resolved
src/pages/components/progress-indicator/images/progress-indicator-usage-5.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good Aubrey, just a couple comments:
src/pages/components/progress-indicator/images/progress-indicator-usage-6.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had 3 overall comments of some of the images being 12 columns instead of 8 columns.
alignment. | ||
|
||
<Row> | ||
<Column colLg={8}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
|
||
| State | Description | | ||
| ----------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| Completed | A step is complete when a user has filled out the required information within a step and progressed to the following step. When possible, use validation to confirm that a step has been completed before the user continues. All steps that have been completed are indicated by an outlined circle with a checkmark and a blue active line. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider formatting the state names in italic text
Closes #3464
This is issue is a complete rewrite of the progress indicator usage tab, which does not currently follow our template or provide sufficient information.
Changelog
New