Ally updates for tabs style #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Took out focus states for scroll icons • Updated to latest style template • Updated disabled tokens for text and icon in contained tabs • Updated image ratios from fixed to normal ratios on non-structure images
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
• updated image to include close icon instead of bee • fixed a few typos and added headers for clarity
going to see what it looks like without breaks
yikes. added breaks back in.
trying to figure out why line breaks aren't working
still trying to figure out why breaks aren't working
break still not working
laurenmrice
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Amazing work, Tracey!! 🎉
I was thinking, should we include links to the variants table under the 'Usage' tab (link), or would it be better to address that separately?
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
|
@Kritvi-bhatia17 i am about to update the usage tab so will include the link update in that PR! good catch. |
Kritvi-bhatia17
approved these changes
Apr 8, 2024
alisonjoseph
approved these changes
Apr 9, 2024
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3827
Addresses A11y concerns for scrollable focus states and general updates to tokens and images.
Will open separate issues for focus states around whole tab groups and line tab border color because they require further investigation.
Changelog
• Took out focus states for scroll icons
• Updated to latest style template
• Updated disabled tokens for text and icon in contained tabs
• Updated image ratios from fixed to normal ratios on non-structure images