-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ally updates for tabs style #3971
Ally updates for tabs style #3971
Conversation
• Took out focus states for scroll icons • Updated to latest style template • Updated disabled tokens for text and icon in contained tabs • Updated image ratios from fixed to normal ratios on non-structure images
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
• updated image to include close icon instead of bee • fixed a few typos and added headers for clarity
going to see what it looks like without breaks
yikes. added breaks back in.
trying to figure out why line breaks aren't working
still trying to figure out why breaks aren't working
break still not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good Tracey 🌟!! Just a couple things:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, Tracey!! 🎉
I was thinking, should we include links to the variants table
under the 'Usage' tab (link), or would it be better to address that separately?
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
@Kritvi-bhatia17 i am about to update the usage tab so will include the link update in that PR! good catch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @kingtraceyj! 🔥
Closes #3827
Addresses A11y concerns for scrollable focus states and general updates to tokens and images.
Will open separate issues for focus states around whole tab groups and line tab border color because they require further investigation.
Changelog
• Took out focus states for scroll icons
• Updated to latest style template
• Updated disabled tokens for text and icon in contained tabs
• Updated image ratios from fixed to normal ratios on non-structure images