feat: update to gatsby-theme-carbon v4 and gatsby v5 #3979
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Gatsby upgrade testing
|
Thanks @tay1orjones! Good catches. The video's that aren't displaying in previews are all Vimeo videos with domain restrictions set on them, so should be fine once live. I fixed the other display issues. |
alisonjoseph
changed the title
There was a problem hiding this comment.
Here's one thing, the lists aren't running the full width of the text area. This one is on the typography page. Compared to the AS-IS
There was a problem hiding this comment.
Looks like the images aren't centering in the fixed image container on the style tab pages. Example here on the accordion page. Compared to the AS-IS example.
There was a problem hiding this comment.
The left/right padding on the demo is slightly off, compared to the as-is.
|
@alisonjoseph Ok ^ that's all I really found and its small stuff. |
|
Deployment failed with the following error: |
|
@aagonzales @tay1orjones issues should be fixed when you have a chance to re-review 🙏 |
Ref carbon-design-system/gatsby-theme-carbon#1426
Testing
Test all types of pages thoroughly. icons, pictograms, typography, status indicators, colors, a11y, live demo, search, charts etc