-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ai-alina #4059
ai-alina #4059
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@alina-jacob I commented here the changes we were talking about in Slack. I only commented in the text input page. The number input will need similar updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alina! nice work 🔥
Just a few minor fixes
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
Co-authored-by: Kritvi <158570656+Kritvi-bhatia17@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few more formatting things.
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Vercel link for preview: https://carbondesignsystem-git-fork-alina-j-32ea40-carbon-design-system.vercel.app/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alina-jacob, everything else seems great with the changes/updates! ✨
Just a quick question: since number input & text input include both default and fluid states, should we display both states under the usage tab under 'AI presence' section? 🤔
The guideline doc showed just default so went with that, should we be showing default and fluid states for the usage tab as well @aagonzales? |
@alina-jacob I believe we discussed this in Slack, but we decided to include both the default and fluid tabs. Part of the work is also to now avoid the word "default" in the copy text. It should be changed to "non-AI" instead of "default" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Ship it!
Hi @alina-jacob, just a small note - you might need to add the page description on the Number Input STYLE tab, similar to the Text Input. |
Closes ##4036 and #4039
Changelog
New
Added in the Usage tab
Added in the Style tab