[Structured list] Implement feature flag in live demo #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Nice work, @2nikhiltom! 🔥
I'm wondering if we should stick with the name "Visible" or choose something closer to what we have in Tiles, like "Selectable with Improved Accessibility (unstable)".
What do you think? @laurenmrice
|
@Kritvi-bhatia17 I think what you suggested makes sense and is aligned more with what we already do for this in the Tiles live demo. |
Kritvi-bhatia17
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Got it @laurenmrice, thanks for validating!
@2nikhiltom now you can update the name from "Visible Icons" to "Selectable with Improved Accessibility (unstable)"
guidari
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4064, #4100
Adds
enable-v12-structured-list-visible-iconsflag Implement in live demoChangelog
New
Adds a new variant:
experimental-feature-flags-structuredlist--selectionRemoved
Removed a variant :
Simple(As part of #4100)Note
simplevariant in React storybook as wellPlease review and confirm the removal of
simplevariantTesting / Reviewing
Review the live demo of structured list under
Visible Iconslabel