-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Structured list] Implement feature flag in live demo #4101
[Structured list] Implement feature flag in live demo #4101
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @2nikhiltom! 🔥
I'm wondering if we should stick with the name "Visible" or choose something closer to what we have in Tiles, like "Selectable with Improved Accessibility (unstable)".
What do you think? @laurenmrice
@Kritvi-bhatia17 I think what you suggested makes sense and is aligned more with what we already do for this in the Tiles live demo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it @laurenmrice, thanks for validating!
@2nikhiltom now you can update the name from "Visible Icons" to "Selectable with Improved Accessibility (unstable)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Closes #4064, #4100
Adds
enable-v12-structured-list-visible-icons
flag Implement in live demoChangelog
New
Adds a new variant:
experimental-feature-flags-structuredlist--selection
Removed
Removed a variant :
Simple
(As part of #4100)Note
simple
variant in React storybook as wellPlease review and confirm the removal of
simple
variantTesting / Reviewing
Review the live demo of structured list under
Visible Icons
label