Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(structured list) feature flag usage, style, code tab update #4258

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Sep 11, 2024

Closes #4224

This PR updates the Structured list component Usage, Style, and Code tabs to include feature flag information and images. The content on the Usage and Style tabs have also been updated with the new content templates.

Note: Links in various places to the "Feature Flag tab" have not been updated yet, because that page is not live yet.


Changelog

New

Usage:

  • Page tag
  • Content
  • Images

Style:

  • Content
  • Images

Code:

  • Resource card tag
  • Content

Changed

  • Content and images

Removed

  • Images and content that needed to be taken out

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 8:21pm

@laurenmrice
Copy link
Member Author

laurenmrice commented Sep 11, 2024

Need dev help

Cli format and Vercel preview are both failing. I tried to use the command you gave in slack and ran yarn format but no luck.

Usage tab:

  • There needs to be a Medium height size, Blue tag, that says Feature flag above the page description like below:
🟩 Usage tab tag spacing specs

Code tab:

  • There needs to be a Medium height size, Blue tag, that says Feature flag in the React resource card like below:
🟩 Resource card with tag spec

@laurenmrice laurenmrice changed the title docs: feature flag structured list usage, style, and code tab update docs(structured list) feature flag usage, style, code tab update Sep 12, 2024
@laurenmrice laurenmrice marked this pull request as ready for review September 20, 2024 12:30
@laurenmrice laurenmrice requested a review from a team as a code owner September 20, 2024 12:30
Co-authored-by: Anna Gonzales <agonz@us.ibm.com>
@laurenmrice
Copy link
Member Author

laurenmrice commented Oct 10, 2024

@aagonzales Yeah, this part has been really tricky to deal with and I agree it currently looks strange. I will try one of those suggestions out. I think I like the separate H3 section instead of adding a third tab.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! The only thing I saw was on the style tab with the image under With background interactive state color the tabbed image kind of jumps some when tabbing between them. Not really a blocker though so I'm going to go ahead and approve.

@laurenmrice
Copy link
Member Author

I see it! I am fixing it before it merges in. Thank you!

@kodiakhq kodiakhq bot merged commit 2605bef into carbon-design-system:main Oct 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Flags] Structured list: add feature flag content to Usage, Style, and Code tabs
5 participants