Skip to content

Commit

Permalink
docs(number-input): avoid double helper text (#1771)
Browse files Browse the repository at this point in the history
  • Loading branch information
emyarod authored and asudoh committed Feb 11, 2019
1 parent 2be09fa commit 02bd5aa
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/components/number-input/number-input.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,10 @@
<div data-invalid data-numberinput
class="{{@root.prefix}}--number {{#if light}}{{@root.prefix}}--number--light{{/if}} {{@root.prefix}}--number--helpertext">
<label for="number-input4" class="{{@root.prefix}}--label">Number Input label</label>
{{#if @root.featureFlags.componentsX}}
<div class="{{@root.prefix}}--form__helper-text">
Optional helper text here; if message is more than one line text should wrap (~100 character count maximum)
</div>
{{#if @root.featureFlags.componentsX}}
<div class="{{@root.prefix}}--number__input-wrapper">
<input id="number-input4" type="number" min="0" max="100" value="1">
{{ carbon-icon 'WarningFilled16' class=(add @root.prefix '--number__invalid')}}
Expand Down Expand Up @@ -239,6 +239,9 @@
</div>
{{/if}}
{{#unless @root.featureFlags.componentsX}}
<div class="{{@root.prefix}}--form-requirement">
Invalid number
</div>
<div class="{{@root.prefix}}--form__helper-text">
Optional helper text here; if message is more than one line text should wrap (~100 character count maximum)
</div>
Expand Down

0 comments on commit 02bd5aa

Please sign in to comment.