Skip to content

Commit

Permalink
Merge branch 'main' into logical-properties
Browse files Browse the repository at this point in the history
  • Loading branch information
tw15egan authored Sep 6, 2023
2 parents 8285514 + f855bc6 commit 22b232c
Show file tree
Hide file tree
Showing 11 changed files with 932 additions and 301 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/contribution-buddy.yml

This file was deleted.

35 changes: 35 additions & 0 deletions .github/workflows/contribution-proposal.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.

# GitHub recommends pinning actions to a commit SHA.
# To get a newer version, you will need to update the SHA.
# You can also reference a tag or branch, but the action may change without warning
name: Add comment on enhancement issue
on:
issues:
types: [labeled, opened]

permissions:
issues: write

jobs:
add-comment:
name: If new enhancement issue is submitted, then post the following comment.
runs-on: ubuntu-latest
steps:
- name: Add comment
if: github.event.label.name == format('type{0} enhancement', ':')
uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 #v6.4.1
with:
script: |
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'Thank you for submitting a feature request. Here’s what to expect next.
Your proposal is open and is now being [triaged](https://github.com/orgs/carbon-design-system/projects/51/views/1) by the Carbon team.
If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request volunteers from the community.
Read the full triaging workflow [here](https://github.com/carbon-design-system/carbon/blob/main/docs/guides/support.md#type-enhancement-).'
})
29 changes: 0 additions & 29 deletions .github/workflows/label-actions.yml

This file was deleted.

34 changes: 34 additions & 0 deletions .github/workflows/proposal-not-pursuing.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.

# GitHub recommends pinning actions to a commit SHA.
# To get a newer version, you will need to update the SHA.
# You can also reference a tag or branch, but the action may change without warning
name: Add comment on enhancement issue
on:
issues:
types: [labeled, opened]

permissions:
issues: write

jobs:
add-comment:
name: If new enhancement issue is submitted, then post the following comment.
runs-on: ubuntu-latest
steps:
- name: Add comment
if: github.event.label.name == ${{format('type{0} enhancement', ':')}} #v6.4.1
with:
script: |
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'Thank you for submitting a feature request. Here’s what to expect next.
Your proposal is open and is now being [triaged](https://github.com/orgs/carbon-design-system/projects/51/views/1) by the Carbon team.
If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request volunteers from the community.
Read the full triaging workflow [here](https://github.com/carbon-design-system/carbon/blob/main/docs/guides/support.md#type-enhancement-).'
})
23 changes: 23 additions & 0 deletions e2e/components/Link/Link-test.avt.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,27 @@ test.describe('Link @avt', () => {
'components-link--paired-with-icon'
);
});

// Prevent timeout
test.slow('accessibility-checker keyboard nav', async ({ page }) => {
await visitStory(page, {
component: 'Link',
id: 'components-link--default',
globals: {
theme: 'white',
},
});

// Checking focus
const link = page.getByRole('link');
await expect(link).toBeVisible();
await page.keyboard.press('Tab');
await expect(link).toBeFocused();

// Checking if the link was triggered
await page.keyboard.press('Enter');
await expect(page).toHaveURL(
'iframe.html?id=components-link--default&viewMode=story&globals=theme:white#'
);
});
});
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
}
},
"lint-staged": {
"**/*.js": [
"**/*.{js,jsx,ts,tsx}": [
"prettier --cache --write",
"eslint"
],
Expand Down
Loading

0 comments on commit 22b232c

Please sign in to comment.