Skip to content

Commit

Permalink
Merge branch 'master' into text-area-disabled-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
aagonzales authored Jan 9, 2020
2 parents 125a16e + f87a204 commit 2682088
Show file tree
Hide file tree
Showing 28 changed files with 297 additions and 340 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/accessibility-issue.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Accessibility Issue
about: Report an accessibility or usability issue
title: ''
labels: 'type: a11y, squad: system'
labels: 'type: a11y'
assignees: ''
---

Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug-report.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: "Bug Report 🐛"
name: 'Bug Report 🐛'
about: Something isn't working as expected? Here is the right place to report.
title: ''
labels: "type: bug 🐛, squad: system"
labels: 'type: bug 🐛'
assignees: ''
---

Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/feature-request-or-enhancement.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: "Feature request or enhancement 💡"
name: 'Feature request or enhancement 💡'
about: Suggest an idea for this project
title: ''
labels: "type: enhancement 💡, squad: system"
labels: 'type: enhancement 💡'
assignees: ''
---

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Question ❓
about: Usage question or discussion about Carbon components
title: ''
labels: 'type: question ❓, squad: system'
labels: 'type: question ❓'
assignees: ''
---

Expand Down
123 changes: 0 additions & 123 deletions .github/labeler.yml

This file was deleted.

13 changes: 0 additions & 13 deletions .github/workflows/labeler.yml

This file was deleted.

15 changes: 11 additions & 4 deletions packages/components/docs/sass.md
Original file line number Diff line number Diff line change
Expand Up @@ -3692,6 +3692,7 @@ $spacing-05: $carbon--spacing-05;
- **Alias**: `carbon--spacing-05`
- **Used by**:
- [carbon--theme [mixin]](#carbon--theme-mixin)
- [accordion [mixin]](#accordion-mixin)
- [checkbox [mixin]](#checkbox-mixin)
- [snippet [mixin]](#snippet-mixin)
- [data-table-v2-action [mixin]](#data-table-v2-action-mixin)
Expand Down Expand Up @@ -5737,8 +5738,8 @@ $carbon--theme--v9: map-merge(
$carbon--theme--white,
(
interactive-01: #3d70b2,
interactive-02: #5a6872,
interactive-03: #5a6872,
interactive-02: #4d5358,
interactive-03: #3d70b2,
interactive-04: #3d70b2,
ui-background: #f4f7fb,
ui-01: #ffffff,
Expand Down Expand Up @@ -5790,8 +5791,8 @@ $carbon--theme--v9: map-merge(
skeleton-01: rgba(61, 112, 178, 0.1),
skeleton-02: rgba(61, 112, 178, 0.1),
brand-01: #3d70b2,
brand-02: #5a6872,
brand-03: #5a6872,
brand-02: #4d5358,
brand-03: #3d70b2,
active-01: #dfeafa,
hover-field: #eef4fc,
)
Expand Down Expand Up @@ -12694,6 +12695,11 @@ Accordion styles
}
}

.#{$prefix}--accordion--end.#{$prefix}--skeleton
.#{$prefix}--accordion__arrow {
margin-left: $spacing-05;
}

.#{$prefix}--skeleton
.#{$prefix}--accordion__heading:focus
.#{$prefix}--accordion__arrow {
Expand Down Expand Up @@ -12723,6 +12729,7 @@ Accordion styles
- [carbon--spacing-03 [variable]](#carbon--spacing-03-variable)
- [carbon--spacing-06 [variable]](#carbon--spacing-06-variable)
- [spacing-03 [variable]](#spacing-03-variable)
- [spacing-05 [variable]](#spacing-05-variable)

## breadcrumb

Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/components/accordion/_accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@
}
}

.#{$prefix}--accordion--end.#{$prefix}--skeleton
.#{$prefix}--accordion__arrow {
margin-left: $spacing-05;
}

.#{$prefix}--skeleton
.#{$prefix}--accordion__heading:focus
.#{$prefix}--accordion__arrow {
Expand Down
8 changes: 4 additions & 4 deletions packages/elements/docs/sass.md
Original file line number Diff line number Diff line change
Expand Up @@ -5367,8 +5367,8 @@ $carbon--theme--v9: map-merge(
$carbon--theme--white,
(
interactive-01: #3d70b2,
interactive-02: #5a6872,
interactive-03: #5a6872,
interactive-02: #4d5358,
interactive-03: #3d70b2,
interactive-04: #3d70b2,
ui-background: #f4f7fb,
ui-01: #ffffff,
Expand Down Expand Up @@ -5420,8 +5420,8 @@ $carbon--theme--v9: map-merge(
skeleton-01: rgba(61, 112, 178, 0.1),
skeleton-02: rgba(61, 112, 178, 0.1),
brand-01: #3d70b2,
brand-02: #5a6872,
brand-03: #5a6872,
brand-02: #4d5358,
brand-03: #3d70b2,
active-01: #dfeafa,
hover-field: #eef4fc,
)
Expand Down
13 changes: 10 additions & 3 deletions packages/react/src/components/ComboBox/ComboBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,16 +280,22 @@ export default class ComboBox extends React.Component {
const titleClasses = cx(`${prefix}--label`, {
[`${prefix}--label--disabled`]: disabled,
});
const comboBoxHelperId = !helperText
? undefined
: `combobox-helper-text-${this.comboBoxInstanceId}`;
const comboBoxLabelId = `combobox-label-${this.comboBoxInstanceId}`;
const title = titleText ? (
<label htmlFor={id} className={titleClasses}>
<label id={comboBoxLabelId} htmlFor={id} className={titleClasses}>
{titleText}
</label>
) : null;
const helperClasses = cx(`${prefix}--form__helper-text`, {
[`${prefix}--form__helper-text--disabled`]: disabled,
});
const helper = helperText ? (
<div className={helperClasses}>{helperText}</div>
<div id={comboBoxHelperId} className={helperClasses}>
{helperText}
</div>
) : null;
const wrapperClasses = cx(`${prefix}--list-box__wrapper`);
const comboBoxA11yId = `combobox-a11y-${this.comboBoxInstanceId}`;
Expand Down Expand Up @@ -335,7 +341,8 @@ export default class ComboBox extends React.Component {
<ListBox.Field
id={id}
disabled={disabled}
translateWithId={translateWithId}
aria-labelledby={comboBoxLabelId}
aria-describedby={comboBoxHelperId}
{...getButtonProps({
disabled,
onClick: this.onToggleClick(isOpen),
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Dropdown/Dropdown-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe('Dropdown', () => {

beforeEach(() => {
wrapper = mount(<Dropdown titleText="Email Input" {...mockProps} />);
renderedLabel = wrapper.find('label');
renderedLabel = wrapper.find('span[className="bx--label"]');
});

it('renders a title', () => {
Expand Down
Loading

0 comments on commit 2682088

Please sign in to comment.