test(tag): add aria-label test

carbon-design-system · Dec 11, 2019 · 846bd21 · 846bd21
1 parent 1c7d3b0
commit 846bd21
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/react/src/components/Tag/Tag-test.js b/packages/react/src/components/Tag/Tag-test.js
@@ -33,17 +33,16 @@ describe('Tag', () => {
   describe('with a screenreader', () => {
     afterEach(cleanup);
 
-    it('should have an aria-label', () => {
-      const { container } = render(
-        <Tag data-id="aliens">This is not a tag</Tag>
-      );
+    it('filtered variant should have appropriate aria-label', () => {
+      const { container } = render(<Tag filter>This is not a tag</Tag>);
+
       const button = container.querySelector('[aria-label]');
       expect(button).toBeInstanceOf(HTMLElement);
 
       const ariaLabel = button.getAttribute('aria-label');
       expect(ariaLabel).toBeDefined();
 
-      expect(ariaLabel).toEqual('Clear Filter This is not a tag');
+      expect(ariaLabel).toEqual('Clear filter This is not a tag');
     });
   });
 

diff --git a/packages/react/src/components/Tag/Tag.js b/packages/react/src/components/Tag/Tag.js
@@ -43,7 +43,11 @@ const Tag = ({
   return filter ? (
     <button
       className={tagClasses}
-      aria-label={`${title} ${children}` || `Clear filter ${children}`}
+      aria-label={
+        title !== undefined
+          ? `${title} ${children}`
+          : `Clear filter ${children}`
+      }
       {...other}>
       {children !== null && children !== undefined ? children : TYPES[type]}
       <Close16 />