-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design tokens with latest values #10292
Comments
@aagonzales are there any values in particular that stood out as wrong that I should add to the checklist to be changed before doing an overall audit? |
Just the ones that were brought up in the discussion thread. |
@aagonzales I have As a reference to those reading this issue, this is the discussion that we're referring to: #10247 (comment) |
Color token value audit
|
@aagonzales
This link shows each one in context. Do you think these should be updated to something else so we can remove |
@aagonzales
This link shows each one in context. Same deal - I can update them if you'd like to aim for removing |
Yeah I know I talked to @joshblack about this and maybe we never opened a ticket for it but anywhere where So they're in use now but they shouldn't be. Code needs to be updated to replace the disabled tokens. Update: Here's the issue #9832 (comment) |
Before our RC0 release, we need to go through the tokens defined in our themes package and verify that the values match the latest in: https://carbondesignsystem.notion.site/final-List-of-new-tokens-c507394e43fe4daa9f0cd0eedb25d1e4
Checklist
highlight
should beblue-80
ing100
toggle-off
should begray-60
ing100
The text was updated successfully, but these errors were encountered: