Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): update tokens to correct values #10525

Merged
merged 8 commits into from
Jan 27, 2022

Conversation

tay1orjones
Copy link
Member

Closes #10292

Updates various tokens for next themes, as specified in the root issue: #10292 (comment)

Changelog

Changed

  • theme: updated token values

Testing / Reviewing

  • Check out the elements theme v11 preview - the token changes should be reflected and they should match what's in the notion doc here

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: fcc4f97

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f2f95600fb7e00072033c2

😎 Browse the preview: https://deploy-preview-10525--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fcc4f97

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f2f9564463a800080b603a

😎 Browse the preview: https://deploy-preview-10525--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fcc4f97

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f2f95664f93400071a990e

😎 Browse the preview: https://deploy-preview-10525--carbon-components-react.netlify.app/

@aagonzales
Copy link
Member

aagonzales commented Jan 26, 2022

@tay1orjones Weird, in the code I see the correct token for layer-hover-01 but in the preview its showing a different token name in the white and g10 themes. Same with layer-hover-03, field-hover-01 and field-hover-03.

image

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good, its just the preview that's showing a few wrong tokens for some reason 🤷‍♀️ . Going to approve though since the code is correct.

@tay1orjones
Copy link
Member Author

@aagonzales Great catch! It looks like white-hover and gray-10-hover have the same value, so we have to choose which one to use when there is a name collision. The preview site was just grabbing the wrong name for that value. I pushed an update that should fix 👍

@kodiakhq kodiakhq bot merged commit d0c0791 into carbon-design-system:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update design tokens with latest values
4 participants