-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): update tokens to correct values #10525
fix(theme): update tokens to correct values #10525
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: fcc4f97 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f2f95600fb7e00072033c2 😎 Browse the preview: https://deploy-preview-10525--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: fcc4f97 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f2f9564463a800080b603a 😎 Browse the preview: https://deploy-preview-10525--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: fcc4f97 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f2f95664f93400071a990e 😎 Browse the preview: https://deploy-preview-10525--carbon-components-react.netlify.app/ |
@tay1orjones Weird, in the code I see the correct token for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good, its just the preview that's showing a few wrong tokens for some reason 🤷♀️ . Going to approve though since the code is correct.
…collisions for white theme values
@aagonzales Great catch! It looks like |
Closes #10292
Updates various tokens for
next
themes, as specified in the root issue: #10292 (comment)Changelog
Changed
Testing / Reviewing