-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add enable counter for fluid text input #18281
base: main
Are you sure you want to change the base?
fix: add enable counter for fluid text input #18281
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18281 +/- ##
==========================================
+ Coverage 84.16% 84.31% +0.15%
==========================================
Files 404 404
Lines 14350 14359 +9
Branches 4649 4656 +7
==========================================
+ Hits 12077 12107 +30
+ Misses 2111 2089 -22
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
Closes #16938
Closes #18280
Added enable counter for fluid text input
Fixed stylings for Text area as word count overlaps its label
Changelog
New
Changed
Testing / Reviewing
Test Fluid text area and fluid text input it should have enableCounter as prop and word count should be in its correct position