Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enable counter for fluid text input #18281

Merged

Conversation

riddhybansal
Copy link
Contributor

Closes #16938
Closes #18280

Added enable counter for fluid text input
Fixed stylings for Text area as word count overlaps its label

Changelog

New

  • Added enable counter for fluid text input

Changed

  • Fixed stylings for Fluid Text area as word count overlaps its label

Testing / Reviewing

Test Fluid text area and fluid text input it should have enableCounter as prop and word count should be in its correct position

@riddhybansal riddhybansal requested a review from a team as a code owner December 27, 2024 15:00
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 55f1abb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67aa1f8fcb29660008ab6d27
😎 Deploy Preview https://deploy-preview-18281--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 55f1abb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67aa1f8f2e29b800084192f8
😎 Deploy Preview https://deploy-preview-18281--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 55f1abb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67aa1f8fc673240008781118
😎 Deploy Preview https://deploy-preview-18281--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@riddhybansal riddhybansal requested a review from a team as a code owner December 27, 2024 17:21
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (55280bf) to head (55f1abb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18281   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         408      408           
  Lines       14470    14470           
  Branches     4710     4660   -50     
=======================================
  Hits        12162    12162           
  Misses       2142     2142           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theh fluid text area counter looks good to me
image

the fluid text input counter seems to be missing though

image

@riddhybansal
Copy link
Contributor Author

theh fluid text area counter looks good to me image

the fluid text input counter seems to be missing though

image

hey you need to enable both enableCounter and maxCount to see that .

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@riddhybansal riddhybansal requested review from a team as code owners February 10, 2025 15:47
@riddhybansal riddhybansal added this pull request to the merge queue Feb 11, 2025
Merged via the queue into carbon-design-system:main with commit affc44d Feb 11, 2025
37 checks passed
@riddhybansal riddhybansal deleted the enable_counter_fluid_text branch February 11, 2025 09:53
@carbon-automation
Copy link
Contributor

Hey there! v11.76.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fluid Text Area Word Count overlaps label [FluidTextInput]: missing enableCounter
3 participants