-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add enable counter for fluid text input #18281
fix: add enable counter for fluid text input #18281
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18281 +/- ##
=======================================
Coverage 84.04% 84.04%
=======================================
Files 408 408
Lines 14470 14470
Branches 4710 4660 -50
=======================================
Hits 12162 12162
Misses 2142 2142
Partials 166 166 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
affc44d
Hey there! v11.76.0 was just released that references this issue/PR. |
Closes #16938
Closes #18280
Added enable counter for fluid text input
Fixed stylings for Text area as word count overlaps its label
Changelog
New
Changed
Testing / Reviewing
Test Fluid text area and fluid text input it should have enableCounter as prop and word count should be in its correct position