Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(Pagination): Stand alone Small pagination #2634

Closed
okstaticzero opened this issue Jun 14, 2018 · 23 comments
Closed

feat:(Pagination): Stand alone Small pagination #2634

okstaticzero opened this issue Jun 14, 2018 · 23 comments

Comments

@okstaticzero
Copy link
Contributor

The design files show a secondary pagination example (shown below). Any plans to add this?
comp

@okstaticzero okstaticzero changed the title feat:(Pagination): Stan alone Small pagination feat:(Pagination): Stand alone Small pagination Jun 14, 2018
@tw15egan
Copy link
Member

There aren't any plans to add this in at this time, but if this is a component someone would like to tackle we would love contributions! We would probably want to start in the Vanilla repo, as that's where the styles would come from, so I'm going to move this one over there.

@tw15egan
Copy link
Member

Issue moved to IBM/carbon-components #977 via ZenHub

@asudoh asudoh reopened this Feb 22, 2019
@asudoh
Copy link
Contributor

asudoh commented Feb 22, 2019

Re-opened for React variant implementation - @Martskin thanks again for your awesome contribution in vanilla! 🎉

@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@stale
Copy link

stale bot commented Jun 12, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 12, 2019
@asudoh
Copy link
Contributor

asudoh commented Jun 13, 2019

Let's enqueue this for feature enhancement bucket.

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jun 13, 2019
@aagonzales
Copy link
Member

For the record the image shown in the first comment is NOT the approved v10 styling. The styling is correct in the #1812 issue.

@shixiedesign
Copy link
Contributor

shixiedesign commented Jun 26, 2019

To do

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 26, 2019
@asudoh asudoh removed the status: inactive Will close if there's no further activity within a given time label Jul 26, 2019
@carbon-design-system carbon-design-system deleted a comment from stale bot Jul 29, 2019
@stale
Copy link

stale bot commented Aug 28, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 28, 2019
@asudoh asudoh removed the status: inactive Will close if there's no further activity within a given time label Aug 28, 2019
@stale
Copy link

stale bot commented Sep 28, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Sep 28, 2019
@aagonzales aagonzales removed the status: inactive Will close if there's no further activity within a given time label Sep 30, 2019
@aagonzales
Copy link
Member

aagonzales commented Sep 30, 2019

Vanilla versions has been added to the website. The outstanding task here is to make the react version.

@emyarod emyarod self-assigned this Oct 1, 2019
@emyarod
Copy link
Member

emyarod commented Oct 1, 2019

is this component meant to be a 1:1 drop-in replacement for the regular pagination component? if so, I would need some additional clarification for certain scenarios like when the total number of items is unknown for example

@aagonzales
Copy link
Member

aagonzales commented Oct 1, 2019

@emyarod No, it's a new variation. It's essentially a non-table pagination version. Something you'd see at the bottom of a search results page for example.

Like at the bottom of a google search page:
image

Can you show me an example of pagination with the total number of items is unknown?(ie what's the industry standard for handling this?) Is this something we address with our current data table version of pagination?

@aagonzales
Copy link
Member

aagonzales commented Oct 1, 2019

For google it looks like it just keeps counting pages and wouldn't present the ellipse feature. The only controls the user would have are the set of 10 number in the range and a backward/forward function.

image

So ours would looks like:
image

@emyarod
Copy link
Member

emyarod commented Oct 1, 2019

@aagonzales it looks like we currently have a prop called pagesUnknown (introduced in c2de95a), you can see it in action in the story after selecting the knob for it. I'm assuming we will carry that feature over to this variation and we would just remove the ellipses selection menu in this case as you mentioned

@emyarod
Copy link
Member

emyarod commented Oct 2, 2019

I have a few more questions for clarification

have we created a spec for this pagination variation including disabled/hover/focus styles, theme variants etc? some of these details aren't currently shown in the live component example but I'll need to add them

is there a default/minimum/maximum number of pages we want to show in the component (in the cases with and without <select> menu overflow too)?

and based on the mockups in the first post in this issue, will we always show the first and last page numbers?

@aagonzales
Copy link
Member

@emyarod as per this comment #2634 (comment) the image in the first comment is not the final design. The code was contributed to us and we made a lot of decisions on the fly in the PR. #1812

All the state you mention are already part of the vanilla component here, they are also available in the design kit under "pagination/standalone".

Enabled & selected
image

Hover:
image

Focus:
image

Overflow:
image
image

Disabled:
image

From the sandbox here, it looks like the themes are already rendering properly with the correct tokens: https://the-carbon-components.netlify.com/?nav=pagination-nav

@aagonzales
Copy link
Member

aagonzales commented Oct 2, 2019

Min number of pages: 2
Max number of pages before overflow: 10

@emyarod
Copy link
Member

emyarod commented Oct 2, 2019

@aagonzales cool, I was already referring to the resources that you linked. WRT disabled state, I meant a scenario when the entire component is disabled (including the caret buttons and current page indicator) instead of a couple of individual pages like in the image

@aagonzales
Copy link
Member

image
For disabled all numbers and the arrows should use the color token $disabled-02

@stale
Copy link

stale bot commented Nov 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Nov 1, 2019
@asudoh asudoh removed the status: inactive Will close if there's no further activity within a given time label Nov 1, 2019
@joshblack joshblack mentioned this issue Feb 12, 2020
2 tasks
@joshblack joshblack mentioned this issue Mar 2, 2020
82 tasks
@lukefirth
Copy link

Adding a 2¢ to this from some exploration on my team where we're using this as part of a larger 'tile catalog' type component.

I wanted to keep the simplicity of the interactions googles search used for paging back and forth, but I didn't want to lose the versatility of the overflow, even while deep in the pages. In the end I landed here:

image

Note: The overflows would simply let you jump directly to the given page, which would make the pagination assume the appropriate step.

@joshblack joshblack mentioned this issue Mar 27, 2020
79 tasks
@laurenmrice
Copy link
Member

closing as this was merged into react with this pr: #6199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests