-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OverflowMenu not working inside Modal (v10) #3665
Comments
Hi 👋 thank you for reporting! Would you create a reduced case based on https://codesandbox.io/s/github/carbon-design-system/carbon/tree/master/packages/react/examples/codesandbox? |
@asudoh Here it is: https://codesandbox.io/s/codesandbox-c46yh |
Thanks - Would you try adding |
Thanks! I wasn't aware of that property. Could there be any negative effects of just turning off focusTrap? (as opposed to moving the open menu to be inside the focusTrap.) I tried tabing out of the modal and everything seemed to be fine, but I was wondering if there were any other possible effects I should be aware of. |
The only difference I'm aware of is |
I'm going to close this since it seems like the issue was addressed, feel free to comment if you feel like it hasn’t been addressed yet! |
This change eliminates the need for application to put focus sentinel by having `<Modal>`, `<ComposedModal>` and `<FloatingMenu>` automatically put the focus sentinels. This change also add support for reverse-focus-wrap feature to `<Modal>` and `<ComposedModal>`, without needing using 3rd-party `focus-trap-react` library. This helps applications hitting adverse side-effects that `focus-trap-react` library causes (e.g. carbon-design-system#3021, carbon-design-system#3665 and carbon-design-system#4600). Fixes carbon-design-system#3817. Fixes carbon-design-system#4036. Fixes carbon-design-system#4600.
This change eliminates the need for application to put focus sentinel by having `<Modal>`, `<ComposedModal>` and `<FloatingMenu>` automatically put the focus sentinels. This change also add support for reverse-focus-wrap feature to `<Modal>` and `<ComposedModal>`, without needing using 3rd-party `focus-trap-react` library. This helps applications hitting adverse side-effects that `focus-trap-react` library causes (e.g. #3021, #3665 and #4600). Fixes #3817. Fixes #4036. Fixes #4600.
What package(s) are you using?
carbon-components
carbon-components-react
Detailed description
Steps to reproduce the issue
Create a
Modal
with anOverflowMenu
inside it.Have an
OverflowMenuItem
item with anonClick
handler.Click on the menu item to see it doesn't work.
Additional information
The text was updated successfully, but these errors were encountered: