Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New token: text-error #5024

Closed
2 of 3 tasks
aagonzales opened this issue Jan 13, 2020 · 4 comments · Fixed by #5240
Closed
2 of 3 tasks

New token: text-error #5024

aagonzales opened this issue Jan 13, 2020 · 4 comments · Fixed by #5240

Comments

@aagonzales
Copy link
Member

aagonzales commented Jan 13, 2020

Red-50 being used for error messages is not accessible on Gray80 or Gray70 in the dark themes. We need to add a new token that controls the value of the error messages that's not attached to support-01. The name we want to go with is text-error but also open to that since it a little breaks our token naming logic.

To-do:

  • Add new $text-error token
  • Update $support-01 in Gray-90 Theme to Red-40 #ff8389
  • Update all invalid messages in components to use new $text-error token (replaces $support-01)

$text-error

White Gray 10 Gray 90 Gray 100 V9
Red-60 / #da1e28 Red-60 / #da1e28 Red-30 #ffb3b8 Red-40 #ff8389 #e0182d

image
image

@joshblack
Copy link
Contributor

@aagonzales do you know which specific components will need to have this token updated? Or is it just all instances of support-01 should now be text-error?

@aagonzales
Copy link
Member Author

aagonzales commented Jan 31, 2020

Its not all instances of support-01 only instances of support-01 that are text. So basically text in invalid states, which I think are mostly inputs. I can make a list if that's easier.

@joshblack
Copy link
Contributor

@aagonzales if there was a list for components/places where this needs to change it would definitely help out with editing and reviewing 👍

@designertyler
Copy link
Contributor

@aagonzales It looks like TJ searched, found, and updated these components to text-error

  • data-table-inline-edit-cell
  • date-picker
  • dropdown
  • file uploader
  • form
  • number-input
  • select
  • text area

Let me know if that list looks correct or you can add comments in the PR #5240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants