fix(tokens): update color tokens #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
tw15egan
requested review from
a team and
designertyler
and removed request for
a team
|
Deploy preview for the-carbon-components ready! Built with commit 52d7c74 https://deploy-preview-5240--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6e351e1 |
|
Deploy preview for carbon-components-react ready! Built with commit 6e351e1 https://deploy-preview-5240--carbon-components-react.netlify.com |
|
I can't preview the changes but the components not mentioned that also have invalid states are:
|
|
@aagonzales Deploy preview is now available in case you want to take a look. |
|
in the spec I think gonzo has a black adornment on the error icon (i.e. the exclamation mark is black in the dark themes for added contrast. is this right @aagonzales ?
spec
|
aagonzales
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5230
Closes #5024
Updates any text using
$support-01to$text-error. Found by searching forcolor: $support-01in the repo. Also includes small fix forcheckboxChangelog
Changed
$ui-05instead of$icon-01$text-errorinstead of$support-01