Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu items should have role="option" #5368

Closed
enricoberti opened this issue Feb 17, 2020 · 1 comment
Closed

Dropdown menu items should have role="option" #5368

enricoberti opened this issue Feb 17, 2020 · 1 comment
Labels
type: a11y ♿

Comments

@enricoberti
Copy link

[Dropdown]: the ARIA role="option" attribute is missing

Environment

MacOS

Chrome, FF

Storybook's Accessibility Tab

Detailed description

Testing on master, the original issue was open on carbon-addons-iot-react.

It's marked as 'critical', with the info given that

  • Certain ARIA roles must contain particular children
  • Required ARIA child role not present: option

Steps to reproduce the issue

Verify on https://react.carbondesignsystem.com/?path=/story/dropdown--default that role="option" is missing from the dropdown options

Additional information

Possibly a dupe of #5211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dropdown): add a11y role='option' and aria-selected to menu options enricoberti/carbon
1 participant
@enricoberti