Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress Bar step labels look like a link tag but nothing happens when clicking on it #5515

Closed
sabinead opened this issue Mar 3, 2020 · 3 comments · Fixed by #5843
Closed

Progress Bar step labels look like a link tag but nothing happens when clicking on it #5515

sabinead opened this issue Mar 3, 2020 · 3 comments · Fixed by #5843
Labels
role: dev 🤖 type: bug 🐛

Comments

@sabinead
Copy link

sabinead commented Mar 3, 2020

This is a usability issue. The labels of a step look like a link tag. As a user I would expect more information when clicking on the step label but nothing happens.
@emyarod
Copy link
Member

emyarod commented Mar 4, 2020

one idea we could implement is remove the link hover styles unless we know that the progress steps can be interacted with, but I will defer to @carbon-design-system/design on what the desired behavior should be

@joshblack
Copy link
Contributor

cc @laurenmrice

@laurenmrice
Copy link
Member

I would be fine with removing the link hover style on the text if you can not interact with the progress steps. If you can interact with each step, then they should be present.

@joshblack joshblack mentioned this issue Mar 5, 2020
Closed
82 tasks
@aledavila aledavila self-assigned this Mar 26, 2020
@joshblack joshblack mentioned this issue Mar 30, 2020
Closed
79 tasks
@aledavila aledavila removed their assignment Apr 7, 2020
asudoh added a commit to asudoh/carbon-components that referenced this issue Apr 10, 2020
@asudoh
fix(progress-indicator): make unclickable step look non-interactive
e1a80fa 
Fixes carbon-design-system#5515.
asudoh added a commit to asudoh/carbon-components that referenced this issue Apr 10, 2020
@asudoh
fix(progress-indicator): make unclickable step look non-interactive
7f58be1 
Fixes carbon-design-system#5515.
@asudoh asudoh mentioned this issue Apr 10, 2020
Merged
asudoh added a commit that referenced this issue Apr 15, 2020
@asudoh
fix(progress-indicator): make unclickable step look non-interactive (#…
791130d 
…5843)

Fixes #5515.
joshblack pushed a commit to joshblack/carbon that referenced this issue Apr 16, 2020
@asudoh @joshblack
fix(progress-indicator): make unclickable step look non-interactive (c…
c3ff370 
…arbon-design-system#5843)

Fixes carbon-design-system#5515.
joshblack pushed a commit that referenced this issue Apr 21, 2020
@asudoh @joshblack
fix(progress-indicator): make unclickable step look non-interactive (#…
81a4b75 
…5843)

Fixes #5515.
@KJaspers KJaspers mentioned this issue Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(progress-indicator): make unclickable step look non-interactive asudoh/carbon-components
6 participants
@joshblack @emyarod @tw15egan @aledavila @sabinead @laurenmrice