-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pictograms have extra padding #5550
Comments
I do not have permissions to move this into the pictogram repo, otherwise I would have . |
@laurenmrice thanks for the heads up, the repo is still private and is mostly intended for artwork creation and contribution so it might be worth keeping this one here. @oliviaflory thanks for calling attention to this issue. The extra padding around the pictogram is intentional and is actually the corresponding container size for the pictograms as in the image shown below. While the intent is to include this extra space for container shapes in the SVG file for ease of use, it seems like the inclusion of the container space is causing issues with alignment when a container is not needed. I'm not sure how we might address this issue in code but it's something I can bring up with the production team on the brand side and it'll be good to get some perspective from the Carbon folks on how we can avoid this issue moving forward. |
Russ to set up a meeting between Brand team and Carbon to discuss how to deal with this issue. |
@conradennis Hey, can you include Olvia Flory in the meeting, please? We are getting questions around this one a lot, we'd like to stay tuned as well. |
@wonilsuhibm yup will let Russ know to include her. Thanks! |
Closing this in favor of #5693! We're going to move forward with processing the SVGs to be in a 32x32 artboard in code and Sketch 👍 |
What package(s) are you using?
carbon-pictograms
Detailed description
The pictograms have a much larger padding around them than expected from the specs on the IDL documentation
Example of SVG
Expected padding
The extra padding is causing alignment issues between the pictograms and text because the artwork doesn't span to the edge of the container as it did before.
Design intent
using 1px border specs
What is happening
using svg from pictogram package
link to storybook
All pictogram svg files
Is the extra padding around the pictograms an intended, permanent change to the pictogram svgs that designers need to account for?
I would have thought the pictograms would adhere to the size they were drawn to, accounting for the 1px padding specified on the IDL page
All browsers
Digital Design System and Web simplification – launching May 2020
Steps to reproduce the issue
Additional information
The text was updated successfully, but these errors were encountered: