Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pictograms from 48x48 to 32x32 #5693

Closed
joshblack opened this issue Mar 24, 2020 · 2 comments
Closed

Update pictograms from 48x48 to 32x32 #5693

joshblack opened this issue Mar 24, 2020 · 2 comments

Comments

@joshblack
Copy link
Contributor

Related to #5550, we would like to update Pictograms in Sketch and in code to not include the 8px padding around the 32x32 artboard.

This issue will involve updating the following parts of our codebase:

  • pictograms, pictograms-react
    • Update exported assets from the default of 48x48 to 32x32
  • sketch
    • When we have our pictogram command, make sure they render at 32x32 without the padding
@laurenmrice
Copy link
Member

laurenmrice commented Mar 25, 2020

Also make sure Pictograms are rendering correctly into sketch from the plugin.

For example: If i download the pictogram advocate from the website it looks different from the one generated by sketch.

Screen Shot 2020-03-25 at 11 56 36 AM

The svgs are correct.

@joshblack
Copy link
Contributor Author

image

Running into the above issue with resizing assets, it seems like we might be resizing from a 48x48 canvas which is what is causing it to appear smaller than expected. Reaching out to brand now to see if they can help us identify if this is the case.

@joshblack joshblack removed their assignment Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants