-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search): update search to functional component #10072
feat(search): update search to functional component #10072
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 52a023e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61afe09475390f0007c0d54b 😎 Browse the preview: https://deploy-preview-10072--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 52a023e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61afe094789b820008627e45 😎 Browse the preview: https://deploy-preview-10072--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 52a023e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61afe094260ab80008550c03 😎 Browse the preview: https://deploy-preview-10072--carbon-components-react.netlify.app |
…into search-functional-component
…arch-functional-component
@aledavila so sorry about the delay on this PR, would have time to sync up and we can touch base on this? Once again, totally my fault and I wanted to catch up / check-in on this to see how I can help out. |
@joshblack yes please its all finished except for 1 small test I need help on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HECK YEAH 🏄🏾
Closes #10019
Ref #9712
Updates Search component to a functional component
Changelog
Changed
Testing / Reviewing
Make sure search is working