Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): update search to functional component #10072

Merged
merged 20 commits into from
Dec 7, 2021
Merged

feat(search): update search to functional component #10072

merged 20 commits into from
Dec 7, 2021

Conversation

aledavila
Copy link
Contributor

@aledavila aledavila commented Nov 9, 2021 •
edited
Loading

Closes #10019
Ref #9712

Updates Search component to a functional component

Changelog

Changed

  • updated to a functional component and updated tests

Testing / Reviewing

Make sure search is working

@netlify
Copy link

netlify bot commented Nov 9, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 52a023e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61afe09475390f0007c0d54b

😎 Browse the preview: https://deploy-preview-10072--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Nov 9, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 52a023e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61afe094789b820008627e45

😎 Browse the preview: https://deploy-preview-10072--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 9, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 52a023e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61afe094260ab80008550c03

😎 Browse the preview: https://deploy-preview-10072--carbon-components-react.netlify.app

@aledavila aledavila marked this pull request as ready for review November 11, 2021 07:51
@aledavila aledavila requested a review from a team as a code owner November 11, 2021 07:51
@aledavila aledavila changed the title [WIP] Search functional component feat(search): update search to functional component Nov 11, 2021
@joshblack
Copy link
Contributor

@aledavila so sorry about the delay on this PR, would have time to sync up and we can touch base on this? Once again, totally my fault and I wanted to catch up / check-in on this to see how I can help out.

@aledavila
Copy link
Contributor Author

@joshblack yes please its all finished except for 1 small test I need help on.

dakahn
dakahn approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HECK YEAH 🏄🏾

@kodiakhq kodiakhq bot merged commit c4b8986 into carbon-design-system:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search]: upgrade to functional component
4 participants
@aledavila @joshblack @dakahn @tay1orjones