Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): make the form validation style of list box more specific #1059

Merged
merged 1 commit into from
Sep 4, 2018
Merged

fix(form): make the form validation style of list box more specific #1059

merged 1 commit into from
Sep 4, 2018

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Sep 3, 2018

Fixes #1051.

Changelog

Changed

  • Selector of form validation style for React list box, to be more specific.

Testing / Reviewing

Testing should make sure form validation styles of number input and list box not broken.

alisonjoseph
alisonjoseph approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@alisonjoseph alisonjoseph merged commit aff7b2b into carbon-design-system:master Sep 4, 2018
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 9.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asudoh asudoh mentioned this pull request Feb 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@aledavila aledavila aledavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asudoh @carbon-bot @alisonjoseph @aledavila